diff options
| author | Noah Misch <noah@leadboat.com> | 2024-08-18 12:03:59 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-08-18 12:03:59 -0700 |
| commit | 64740853f07fd1a8314ad68c38298d7e5afe1acc (patch) | |
| tree | 67f94f482953f718df1cf1bd288a3b8216e8c1c5 /src/backend/access/heap/heapam_handler.c | |
| parent | 03e9b958eef44046c0092f1f34da4b2de0f9071d (diff) | |
| download | postgresql-64740853f07fd1a8314ad68c38298d7e5afe1acc.tar.gz postgresql-64740853f07fd1a8314ad68c38298d7e5afe1acc.zip | |
Fix comments on wal_level=minimal, CREATE TABLESPACE and CREATE DATABASE.
Commit 97ddda8a82ac470ae581d0eb485b6577707678bc removed the rmtree()
behavior from XLOG_TBLSPC_CREATE, obsoleting that part of the comment.
The comment's point about XLOG_DBASE_CREATE was wrong when commit
fa0f466d5329e10b16f3b38c8eaf5306f7e234e8 introduced the point. (It
would have been accurate if that commit had predated commit
fbcbc5d06f53aea412130deb52e216aa3883fb8d introducing the second
checkpoint of CREATE DATABASE.) Nothing can skip log_smgrcreate() on
the basis of wal_level=minimal, so don't comment on that.
Commit c6b92041d38512a4176ed76ad06f713d2e6c01a8 expanded WAL skipping
from five specific operations to relfilenodes generally, hence the
CreateDatabaseUsingFileCopy() comment change.
Discussion: https://postgr.es/m/20231008022204.cc@rfd.leadboat.com
Diffstat (limited to 'src/backend/access/heap/heapam_handler.c')
| -rw-r--r-- | src/backend/access/heap/heapam_handler.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c index e28047c201a..1c6da286d43 100644 --- a/src/backend/access/heap/heapam_handler.c +++ b/src/backend/access/heap/heapam_handler.c @@ -605,9 +605,7 @@ heapam_relation_set_new_filelocator(Relation rel, /* * If required, set up an init fork for an unlogged table so that it can - * be correctly reinitialized on restart. Recovery may remove it while - * replaying, for example, an XLOG_DBASE_CREATE* or XLOG_TBLSPC_CREATE - * record. Therefore, logging is necessary even if wal_level=minimal. + * be correctly reinitialized on restart. */ if (persistence == RELPERSISTENCE_UNLOGGED) { |