diff options
| author | Robert Haas <rhaas@postgresql.org> | 2016-12-12 15:57:35 -0500 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2016-12-12 15:57:35 -0500 |
| commit | 3856cf9607f41245ec9462519c53f1109e781fc5 (patch) | |
| tree | 8614bf59e364edb0cf2736df75597930cd8444fb /src/backend/access/hash/hashsort.c | |
| parent | 9b3d02c2a9eb93cc4754857361abee449a3fe0cb (diff) | |
| download | postgresql-3856cf9607f41245ec9462519c53f1109e781fc5.tar.gz postgresql-3856cf9607f41245ec9462519c53f1109e781fc5.zip | |
Remove should_free arguments to tuplesort routines.
Since commit e94568ecc10f2638e542ae34f2990b821bbf90ac, the answer is
always "false", and we do not need to complicate the API by arranging
to return a constant value.
Peter Geoghegan
Discussion: http://postgr.es/m/CAM3SWZQWZZ_N=DmmL7tKy_OUjGH_5mN=N=A6h7kHyyDvEhg2DA@mail.gmail.com
Diffstat (limited to 'src/backend/access/hash/hashsort.c')
| -rw-r--r-- | src/backend/access/hash/hashsort.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/backend/access/hash/hashsort.c b/src/backend/access/hash/hashsort.c index 8938ab5b247..12fb78a5c0e 100644 --- a/src/backend/access/hash/hashsort.c +++ b/src/backend/access/hash/hashsort.c @@ -104,15 +104,13 @@ void _h_indexbuild(HSpool *hspool) { IndexTuple itup; - bool should_free; #ifdef USE_ASSERT_CHECKING uint32 hashkey = 0; #endif tuplesort_performsort(hspool->sortstate); - while ((itup = tuplesort_getindextuple(hspool->sortstate, - true, &should_free)) != NULL) + while ((itup = tuplesort_getindextuple(hspool->sortstate, true)) != NULL) { /* * Technically, it isn't critical that hash keys be found in sorted @@ -129,7 +127,5 @@ _h_indexbuild(HSpool *hspool) #endif _hash_doinsert(hspool->index, itup); - if (should_free) - pfree(itup); } } |