diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-09-27 20:47:07 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-09-27 20:50:21 +0200 |
| commit | c8b2ef05f481ef06326d7b9f3eb14b303f215c7e (patch) | |
| tree | 5f72d0b7ee1eebd619c1b91b25f9a35a98f9218f /src/backend/access/gist/gistutil.c | |
| parent | 8caf96de0b7b4ad5beb02b36a158196520c035a7 (diff) | |
| download | postgresql-c8b2ef05f481ef06326d7b9f3eb14b303f215c7e.tar.gz postgresql-c8b2ef05f481ef06326d7b9f3eb14b303f215c7e.zip | |
Convert *GetDatum() and DatumGet*() macros to inline functions
The previous macro implementations just cast the argument to a target
type but did not check whether the input type was appropriate. The
function implementation can do better type checking of the input type.
For the *GetDatumFast() macros, converting to an inline function
doesn't work in the !USE_FLOAT8_BYVAL case, but we can use
AssertVariableIsOfTypeMacro() to get a similar level of type checking.
Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/8528fb7e-0aa2-6b54-85fb-0c0886dbd6ed%40enterprisedb.com
Diffstat (limited to 'src/backend/access/gist/gistutil.c')
| -rw-r--r-- | src/backend/access/gist/gistutil.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c index d4bf0c7563d..1532462317b 100644 --- a/src/backend/access/gist/gistutil.c +++ b/src/backend/access/gist/gistutil.c @@ -280,7 +280,7 @@ gistMakeUnionKey(GISTSTATE *giststate, int attno, bool gistKeyIsEQ(GISTSTATE *giststate, int attno, Datum a, Datum b) { - bool result; + bool result = false; /* silence compiler warning */ FunctionCall3Coll(&giststate->equalFn[attno], giststate->supportCollation[attno], |