diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-09-16 04:27:49 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-09-16 04:27:49 -0400 |
| commit | 0a6cc28500b7a8db7a27cbd0d75e18837fb2e367 (patch) | |
| tree | 128d6c3e8afa7b5eac4fa66a115f4c9a61b28ef9 /src/backend/access/gist/gistscan.c | |
| parent | e6faf910d75027bdce7cd0f2033db4e912592bcc (diff) | |
| download | postgresql-0a6cc28500b7a8db7a27cbd0d75e18837fb2e367.tar.gz postgresql-0a6cc28500b7a8db7a27cbd0d75e18837fb2e367.zip | |
gistendscan() forgot to free so->giststate.
This oversight led to a massive memory leak --- upwards of 10KB per tuple
--- during creation-time verification of an exclusion constraint based on a
GIST index. In most other scenarios it'd just be a leak of 10KB that would
be recovered at end of query, so not too significant; though perhaps the
leak would be noticeable in a situation where a GIST index was being used
in a nestloop inner indexscan. In any case, it's a real leak of long
standing, so patch all supported branches. Per report from Harald Fuchs.
Diffstat (limited to 'src/backend/access/gist/gistscan.c')
| -rw-r--r-- | src/backend/access/gist/gistscan.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/access/gist/gistscan.c b/src/backend/access/gist/gistscan.c index 97a19aa2ac9..5071d46150e 100644 --- a/src/backend/access/gist/gistscan.c +++ b/src/backend/access/gist/gistscan.c @@ -240,6 +240,7 @@ gistendscan(PG_FUNCTION_ARGS) GISTScanOpaque so = (GISTScanOpaque) scan->opaque; freeGISTstate(so->giststate); + pfree(so->giststate); MemoryContextDelete(so->queueCxt); MemoryContextDelete(so->tempCxt); pfree(so->tmpTreeItem); |