diff options
| author | Teodor Sigaev <teodor@sigaev.ru> | 2007-01-31 15:09:45 +0000 |
|---|---|---|
| committer | Teodor Sigaev <teodor@sigaev.ru> | 2007-01-31 15:09:45 +0000 |
| commit | d4c6da152782b580b24cd8b4054eb1b7fb72c5a0 (patch) | |
| tree | 23db426588b5ff2a39981393a3cc4b48397b4294 /src/backend/access/gin/ginbulk.c | |
| parent | 147a3ce149088c913b152e7d37bb92f61bb068dd (diff) | |
| download | postgresql-d4c6da152782b580b24cd8b4054eb1b7fb72c5a0.tar.gz postgresql-d4c6da152782b580b24cd8b4054eb1b7fb72c5a0.zip | |
Allow GIN's extractQuery method to signal that nothing can satisfy the query.
In this case extractQuery should returns -1 as nentries. This changes
prototype of extractQuery method to use int32* instead of uint32* for
nentries argument.
Based on that gincostestimate may see two corner cases: nothing will be found
or seqscan should be used.
Per proposal at http://archives.postgresql.org/pgsql-hackers/2007-01/msg01581.php
PS tsearch_core patch should be sightly modified to support changes, but I'm
waiting a verdict about reviewing of tsearch_core patch.
Diffstat (limited to 'src/backend/access/gin/ginbulk.c')
| -rw-r--r-- | src/backend/access/gin/ginbulk.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/access/gin/ginbulk.c b/src/backend/access/gin/ginbulk.c index f45d5b63958..d3b6f0bceb1 100644 --- a/src/backend/access/gin/ginbulk.c +++ b/src/backend/access/gin/ginbulk.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/gin/ginbulk.c,v 1.7 2007/01/05 22:19:21 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/access/gin/ginbulk.c,v 1.8 2007/01/31 15:09:45 teodor Exp $ *------------------------------------------------------------------------- */ @@ -191,13 +191,13 @@ ginChooseElem(BuildAccumulator *accum, ItemPointer heapptr, Datum *entries, uint * next middle on left part and middle of right part. */ void -ginInsertRecordBA(BuildAccumulator *accum, ItemPointer heapptr, Datum *entries, uint32 nentry) +ginInsertRecordBA(BuildAccumulator *accum, ItemPointer heapptr, Datum *entries, int32 nentry) { uint32 i, nbit = 0, offset; - if (nentry == 0) + if (nentry <= 0) return; i = nentry - 1; |