diff options
| author | Alexander Korotkov <akorotkov@postgresql.org> | 2019-11-19 23:08:14 +0300 |
|---|---|---|
| committer | Alexander Korotkov <akorotkov@postgresql.org> | 2019-11-20 00:04:22 +0300 |
| commit | d5ad7a09afd066dce423f282bb2b338f48614d32 (patch) | |
| tree | b8268a359957b32e29042e1c09845f4c48255e0d /src/backend/access/gin/ginbtree.c | |
| parent | e14641197a5690d92cc48446d0d40f1aec07bac7 (diff) | |
| download | postgresql-d5ad7a09afd066dce423f282bb2b338f48614d32.tar.gz postgresql-d5ad7a09afd066dce423f282bb2b338f48614d32.zip | |
Fix traversing to the deleted GIN page via downlink
Current GIN code appears to don't handle traversing to the deleted page via
downlink. This commit fixes that by stepping right from the delete page like
we do in nbtree.
This commit also fixes setting 'deleted' flag to the GIN pages. Now other page
flags are not erased once page is deleted. That helps to keep our assertions
true if we arrive deleted page via downlink.
Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4
Diffstat (limited to 'src/backend/access/gin/ginbtree.c')
| -rw-r--r-- | src/backend/access/gin/ginbtree.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c index 20adfa21948..8f8cd85db6a 100644 --- a/src/backend/access/gin/ginbtree.c +++ b/src/backend/access/gin/ginbtree.c @@ -187,13 +187,6 @@ ginStepRight(Buffer buffer, Relation index, int lockmode) if (isLeaf != GinPageIsLeaf(page) || isData != GinPageIsData(page)) elog(ERROR, "right sibling of GIN page is of different type"); - /* - * Given the proper lock sequence above, we should never land on a deleted - * page. - */ - if (GinPageIsDeleted(page)) - elog(ERROR, "right sibling of GIN page was deleted"); - return nextbuffer; } |