diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-01-15 12:07:10 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-01-15 12:07:10 -0500 |
| commit | 1c53c4dec3985512f7f2f53c9d76a5295cd0a2dd (patch) | |
| tree | d73a6f1954718d48d622162c98bfa6ca5ddc2422 /src/backend/access/common/reloptions.c | |
| parent | 0944ec54de389b4b8a471ca1f40f1b9d81de1f30 (diff) | |
| download | postgresql-1c53c4dec3985512f7f2f53c9d76a5295cd0a2dd.tar.gz postgresql-1c53c4dec3985512f7f2f53c9d76a5295cd0a2dd.zip | |
Finish reverting "recheck_on_update" patch.
This reverts commit c203d6cf8 and some follow-on fixes, completing the
task begun in commit 5d28c9bd7. If that feature is ever resurrected,
the code will look quite a bit different from this, so it seems best
to start from a clean slate.
The v11 branch is not touched; in that branch, the recheck_on_update
storage option remains present, but nonfunctional and undocumented.
Discussion: https://postgr.es/m/20190114223409.3tcvejfhlvbucrv5@alap3.anarazel.de
Diffstat (limited to 'src/backend/access/common/reloptions.c')
| -rw-r--r-- | src/backend/access/common/reloptions.c | 45 |
1 files changed, 1 insertions, 44 deletions
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c index f5efe94b7b9..cdf1f4af62d 100644 --- a/src/backend/access/common/reloptions.c +++ b/src/backend/access/common/reloptions.c @@ -131,15 +131,6 @@ static relopt_bool boolRelOpts[] = }, { { - "recheck_on_update", - "Recheck functional index expression for changed value after update", - RELOPT_KIND_INDEX, - ShareUpdateExclusiveLock /* since only applies to later UPDATEs */ - }, - true - }, - { - { "security_barrier", "View acts as a row security barrier", RELOPT_KIND_VIEW, @@ -1343,7 +1334,7 @@ fillRelOptions(void *rdopts, Size basesize, break; } } - if (validate && !found && options[i].gen->kinds != RELOPT_KIND_INDEX) + if (validate && !found) elog(ERROR, "reloption \"%s\" not found in parse table", options[i].gen->name); } @@ -1502,40 +1493,6 @@ index_reloptions(amoptions_function amoptions, Datum reloptions, bool validate) } /* - * Parse generic options for all indexes. - * - * reloptions options as text[] datum - * validate error flag - */ -bytea * -index_generic_reloptions(Datum reloptions, bool validate) -{ - int numoptions; - GenericIndexOpts *idxopts; - relopt_value *options; - static const relopt_parse_elt tab[] = { - {"recheck_on_update", RELOPT_TYPE_BOOL, offsetof(GenericIndexOpts, recheck_on_update)} - }; - - options = parseRelOptions(reloptions, validate, - RELOPT_KIND_INDEX, - &numoptions); - - /* if none set, we're done */ - if (numoptions == 0) - return NULL; - - idxopts = allocateReloptStruct(sizeof(GenericIndexOpts), options, numoptions); - - fillRelOptions((void *) idxopts, sizeof(GenericIndexOpts), options, numoptions, - validate, tab, lengthof(tab)); - - pfree(options); - - return (bytea *) idxopts; -} - -/* * Option parser for attribute reloptions */ bytea * |