diff options
| author | Michael Paquier <michael@paquier.xyz> | 2019-11-14 12:34:28 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2019-11-14 12:34:28 +0900 |
| commit | 1bbd608fdae7af314d8e2229e369a45a3da83cd8 (patch) | |
| tree | 55d1a7d30a68b134f0326a0a4aee9e0a08bda800 /src/backend/access/common/reloptions.c | |
| parent | 80ef34fc7075b37fc23f4ab714a5ce60f82400de (diff) | |
| download | postgresql-1bbd608fdae7af314d8e2229e369a45a3da83cd8.tar.gz postgresql-1bbd608fdae7af314d8e2229e369a45a3da83cd8.zip | |
Split handling of reloptions for partitioned tables
Partitioned tables do not have relation options yet, but, similarly to
what's done for views which have their own parsing table, it could make
sense to introduce new parameters for some of the existing default ones
like fillfactor, autovacuum, etc. Splitting things has the advantage to
make the information stored in rd_options include only the necessary
information, reducing the amount of memory used for a relcache entry
with partitioned tables if new reloptions are introduced at this level.
Author: Nikolay Shaplov
Reviewed-by: Amit Langote, Michael Paquier
Discussion: https://postgr.es/m/1627387.Qykg9O6zpu@x200m
Diffstat (limited to 'src/backend/access/common/reloptions.c')
| -rw-r--r-- | src/backend/access/common/reloptions.c | 22 |
1 files changed, 18 insertions, 4 deletions
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c index d8790ad7a38..feb105e1ba1 100644 --- a/src/backend/access/common/reloptions.c +++ b/src/backend/access/common/reloptions.c @@ -1099,9 +1099,11 @@ extractRelOptions(HeapTuple tuple, TupleDesc tupdesc, case RELKIND_RELATION: case RELKIND_TOASTVALUE: case RELKIND_MATVIEW: - case RELKIND_PARTITIONED_TABLE: options = heap_reloptions(classForm->relkind, datum, false); break; + case RELKIND_PARTITIONED_TABLE: + options = partitioned_table_reloptions(datum, false); + break; case RELKIND_VIEW: options = view_reloptions(datum, false); break; @@ -1572,6 +1574,21 @@ build_reloptions(Datum reloptions, bool validate, } /* + * Option parser for partitioned tables + */ +bytea * +partitioned_table_reloptions(Datum reloptions, bool validate) +{ + /* + * There are no options for partitioned tables yet, but this is able to do + * some validation. + */ + return (bytea *) build_reloptions(reloptions, validate, + RELOPT_KIND_PARTITIONED, + 0, NULL, 0); +} + +/* * Option parser for views */ bytea * @@ -1614,9 +1631,6 @@ heap_reloptions(char relkind, Datum reloptions, bool validate) case RELKIND_RELATION: case RELKIND_MATVIEW: return default_reloptions(reloptions, validate, RELOPT_KIND_HEAP); - case RELKIND_PARTITIONED_TABLE: - return default_reloptions(reloptions, validate, - RELOPT_KIND_PARTITIONED); default: /* other relkinds are not supported */ return NULL; |