diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-10-30 20:53:06 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-10-30 20:53:06 +0000 |
| commit | 80559fa9e9657ecfdb92a210971b8d0aa6e82e39 (patch) | |
| tree | 9580827e5de6b17cc7bd66a9c36bc5e119a872c4 /doc/src | |
| parent | 88868d4fbcef1e5d608c0305670465a2a0651c9e (diff) | |
| download | postgresql-80559fa9e9657ecfdb92a210971b8d0aa6e82e39.tar.gz postgresql-80559fa9e9657ecfdb92a210971b8d0aa6e82e39.zip | |
I found a corner case in which it is possible for RI_FKey_check's call
of HeapTupleSatisfiesItself() to trigger a hint-bit update on the tuple:
if the row was updated or deleted by a subtransaction of my own transaction
that was later rolled back. This cannot occur in pre-8.0 of course, so
the hint-bit patch applied a couple weeks ago is OK for existing releases.
But for 8.0 it seems we had better fix things so that RI_FKey_check can
pass the correct buffer number to HeapTupleSatisfiesItself. Accordingly,
add fields to the TriggerData struct to carry the buffer ID(s) for the
old and new tuple(s). There are other possible solutions but this one
seems cleanest; it will allow other AFTER-trigger functions to safely
do tqual.c calls if they want to. Put new fields at end of struct so
that there is no API breakage.
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/trigger.sgml | 25 |
1 files changed, 24 insertions, 1 deletions
diff --git a/doc/src/sgml/trigger.sgml b/doc/src/sgml/trigger.sgml index 56dfec80e6c..942eb0c128a 100644 --- a/doc/src/sgml/trigger.sgml +++ b/doc/src/sgml/trigger.sgml @@ -1,5 +1,5 @@ <!-- -$PostgreSQL: pgsql/doc/src/sgml/trigger.sgml,v 1.36 2004/08/13 16:17:19 tgl Exp $ +$PostgreSQL: pgsql/doc/src/sgml/trigger.sgml,v 1.37 2004/10/30 20:52:46 tgl Exp $ --> <chapter id="triggers"> @@ -256,6 +256,8 @@ typedef struct TriggerData HeapTuple tg_trigtuple; HeapTuple tg_newtuple; Trigger *tg_trigger; + Buffer tg_trigtuplebuf; + Buffer tg_newtuplebuf; } TriggerData; </programlisting> @@ -427,6 +429,27 @@ typedef struct Trigger </para> </listitem> </varlistentry> + + <varlistentry> + <term><structfield>tg_trigtuplebuf</></term> + <listitem> + <para> + The buffer containing tg_trigtuple, or InvalidBuffer if there + is no such tuple or it is not stored in a disk buffer. + </para> + </listitem> + </varlistentry> + + <varlistentry> + <term><structfield>tg_newtuplebuf</></term> + <listitem> + <para> + The buffer containing tg_newtuple, or InvalidBuffer if there + is no such tuple or it is not stored in a disk buffer. + </para> + </listitem> + </varlistentry> + </variablelist> </para> |