diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-08-04 20:29:00 +0200 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-08-04 23:38:27 +0200 |
| commit | 75506195da81d75597a4025b72f8367e6c45f60d (patch) | |
| tree | 55d6df111735a0710ce13d2b831deb3f1e83d728 /doc/src | |
| parent | 4f9ed8f3c5ef0034c98dd34549f85d8c72aab9ad (diff) | |
| download | postgresql-75506195da81d75597a4025b72f8367e6c45f60d.tar.gz postgresql-75506195da81d75597a4025b72f8367e6c45f60d.zip | |
Revert "Add log_statement_sample_rate parameter"
This reverts commit 88bdbd3f746049834ae3cc972e6e650586ec3c9d.
As committed, statement sampling used the existing duration threshold
(log_min_duration_statement) when decide which statements to sample.
The issue is that even the longest statements are subject to sampling,
and so may not end up logged. An improvement was proposed, introducing
a second duration threshold, but it would not be backwards compatible.
So we've decided to revert this feature - the separate threshold should
be part of the feature itself.
Discussion: https://postgr.es/m/CAFj8pRDS8tQ3Wviw9%3DAvODyUciPSrGeMhJi_WPE%2BEB8%2B4gLL-Q%40mail.gmail.com
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/config.sgml | 34 |
1 files changed, 6 insertions, 28 deletions
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index c91e3e15507..1f8d1bdb27d 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -5850,13 +5850,12 @@ local0.* /var/log/postgresql <para> Causes the duration of each completed statement to be logged if the statement ran for at least the specified number of - milliseconds, modulated by <varname>log_statement_sample_rate</varname>. - Setting this to zero prints all statement durations. - <literal>-1</literal> (the default) disables logging statements due to - exceeding duration threshold; for example, if you set it to - <literal>250ms</literal>, then all SQL statements that run 250ms or - longer will be logged. Enabling this parameter can be helpful in - tracking down unoptimized queries in your applications. + milliseconds. Setting this to zero prints all statement durations. + Minus-one (the default) disables logging statement durations. + For example, if you set it to <literal>250ms</literal> + then all SQL statements that run 250ms or longer will be + logged. Enabling this parameter can be helpful in tracking down + unoptimized queries in your applications. Only superusers can change this setting. </para> @@ -5882,27 +5881,6 @@ local0.* /var/log/postgresql </listitem> </varlistentry> - <varlistentry id="guc-log-statement-sample-rate" xreflabel="log_statement_sample_rate"> - <term><varname>log_statement_sample_rate</varname> (<type>real</type>) - <indexterm> - <primary><varname>log_statement_sample_rate</varname> configuration parameter</primary> - </indexterm> - </term> - <listitem> - <para> - Determines the fraction of statements that exceed - <xref linkend="guc-log-min-duration-statement"/> to be logged. - The default is <literal>1.0</literal>, meaning log all such - statements. - Setting this to zero disables logging by duration, same as setting - <varname>log_min_duration_statement</varname> to - <literal>-1</literal>. - <varname>log_statement_sample_rate</varname> is helpful when the - traffic is too high to log all queries. - </para> - </listitem> - </varlistentry> - <varlistentry id="guc-log-transaction-sample-rate" xreflabel="log_transaction_sample_rate"> <term><varname>log_transaction_sample_rate</varname> (<type>real</type>) <indexterm> |