aboutsummaryrefslogtreecommitdiff
path: root/contrib/postgres_fdw/sql/postgres_fdw.sql
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-04-16 13:20:54 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2014-04-16 13:21:20 -0400
commitcad4fe6455bdc9ef1026b4a247eeb588ab3a8bd6 (patch)
treef53f5de76e590f88cb7c8c1cca4c14449b630b33 /contrib/postgres_fdw/sql/postgres_fdw.sql
parent585bca393640b609c54159e1bedd30a89fec5ea8 (diff)
downloadpostgresql-cad4fe6455bdc9ef1026b4a247eeb588ab3a8bd6.tar.gz
postgresql-cad4fe6455bdc9ef1026b4a247eeb588ab3a8bd6.zip
Use AF_UNSPEC not PF_UNSPEC in getaddrinfo calls.
According to the Single Unix Spec and assorted man pages, you're supposed to use the constants named AF_xxx when setting ai_family for a getaddrinfo call. In a few places we were using PF_xxx instead. Use of PF_xxx appears to be an ancient BSD convention that was not adopted by later standardization. On BSD and most later Unixen, it doesn't matter much because those constants have equivalent values anyway; but nonetheless this code is not per spec. In the same vein, replace PF_INET by AF_INET in one socket() call, which wasn't even consistent with the other socket() call in the same function let alone the remainder of our code. Per investigation of a Cygwin trouble report from Marco Atzeri. It's probably a long shot that this will fix his issue, but it's wrong in any case.
Diffstat (limited to 'contrib/postgres_fdw/sql/postgres_fdw.sql')
0 files changed, 0 insertions, 0 deletions