diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2014-11-27 11:12:44 -0500 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2014-11-27 11:13:29 -0500 |
commit | c168ba311228c523923f7ef7699cba96deedcc6d (patch) | |
tree | 35108f646a91dbc33679058aab8a16eeb90da63b /contrib/postgres_fdw/postgres_fdw.c | |
parent | 143b39c1855f8a22f474f20354ee5ee5d2f4d266 (diff) | |
download | postgresql-c168ba311228c523923f7ef7699cba96deedcc6d.tar.gz postgresql-c168ba311228c523923f7ef7699cba96deedcc6d.zip |
Free libxml2/libxslt resources in a safer order.
Mark Simonetti reported that libxslt sometimes crashes for him, and that
swapping xslt_process's object-freeing calls around to do them in reverse
order of creation seemed to fix it. I've not reproduced the crash, but
valgrind clearly shows a reference to already-freed memory, which is
consistent with the idea that shutdown of the xsltTransformContext is
trying to reference the already-freed stylesheet or input document.
With this patch, valgrind is no longer unhappy.
I have an inquiry in to see if this is a libxslt bug or if we're just
abusing the library; but even if it's a library bug, we'd want to adjust
our code so it doesn't fail with unpatched libraries.
Back-patch to all supported branches, because we've been doing this in
the wrong(?) order for a long time.
Diffstat (limited to 'contrib/postgres_fdw/postgres_fdw.c')
0 files changed, 0 insertions, 0 deletions