diff options
| author | Noah Misch <noah@leadboat.com> | 2024-01-08 11:39:56 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-01-08 11:39:56 -0800 |
| commit | d3c5f37dd543498cc7c678815d3921823beec9e9 (patch) | |
| tree | 9c430f23ec95036ded0b8bb16446b30528159c9e /contrib/postgres_fdw/deparse.c | |
| parent | 0efc8318477714600567d15812dc8d15841e269e (diff) | |
| download | postgresql-d3c5f37dd543498cc7c678815d3921823beec9e9.tar.gz postgresql-d3c5f37dd543498cc7c678815d3921823beec9e9.zip | |
Make dblink interruptible, via new libpqsrv APIs.
This replaces dblink's blocking libpq calls, allowing cancellation and
allowing DROP DATABASE (of a database not involved in the query). Apart
from explicit dblink_cancel_query() calls, dblink still doesn't cancel
the remote side. The replacement for the blocking calls consists of
new, general-purpose query execution wrappers in the libpqsrv facility.
Out-of-tree extensions should adopt these. Use them in postgres_fdw,
replacing a local implementation from which the libpqsrv implementation
derives. This is a bug fix for dblink. Code inspection identified the
bug at least thirteen years ago, but user complaints have not appeared.
Hence, no back-patch for now.
Discussion: https://postgr.es/m/20231122012945.74@rfd.leadboat.com
Diffstat (limited to 'contrib/postgres_fdw/deparse.c')
| -rw-r--r-- | contrib/postgres_fdw/deparse.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/postgres_fdw/deparse.c b/contrib/postgres_fdw/deparse.c index 8fc0b2c9c4b..8fc66fa11c7 100644 --- a/contrib/postgres_fdw/deparse.c +++ b/contrib/postgres_fdw/deparse.c @@ -3815,7 +3815,7 @@ appendOrderBySuffix(Oid sortop, Oid sortcoltype, bool nulls_first, * Print the representation of a parameter to be sent to the remote side. * * Note: we always label the Param's type explicitly rather than relying on - * transmitting a numeric type OID in PQexecParams(). This allows us to + * transmitting a numeric type OID in PQsendQueryParams(). This allows us to * avoid assuming that types have the same OIDs on the remote side as they * do locally --- they need only have the same names. */ |