diff options
author | Michael Paquier <michael@paquier.xyz> | 2021-08-19 09:20:13 +0900 |
---|---|---|
committer | Michael Paquier <michael@paquier.xyz> | 2021-08-19 09:20:13 +0900 |
commit | 2576dcfb76aa71e4222bac5a3a43f71875bfa9e8 (patch) | |
tree | e035f807a855e56aee90d73bf63798d19133b1a1 /contrib/btree_gist/btree_utils_num.h | |
parent | 2313dda9d493d3685ac7328b49dc6f5a87c1c295 (diff) | |
download | postgresql-2576dcfb76aa71e4222bac5a3a43f71875bfa9e8.tar.gz postgresql-2576dcfb76aa71e4222bac5a3a43f71875bfa9e8.zip |
Revert refactoring of hex code to src/common/
This is a combined revert of the following commits:
- c3826f8, a refactoring piece that moved the hex decoding code to
src/common/. This code was cleaned up by aef8948, as it originally
included no overflow checks in the same way as the base64 routines in
src/common/ used by SCRAM, making it unsafe for its purpose.
- aef8948, a more advanced refactoring of the hex encoding/decoding code
to src/common/ that added sanity checks on the result buffer for hex
decoding and encoding. As reported by Hans Buschmann, those overflow
checks are expensive, and it is possible to see a performance drop in
the decoding/encoding of bytea or LOs the longer they are. Simple SQLs
working on large bytea values show a clear difference in perf profile.
- ccf4e27, a cleanup made possible by aef8948.
The reverts of all those commits bring back the performance of hex
decoding and encoding back to what it was in ~13. Fow now and
post-beta3, this is the simplest option.
Reported-by: Hans Buschmann
Discussion: https://postgr.es/m/1629039545467.80333@nidsa.net
Backpatch-through: 14
Diffstat (limited to 'contrib/btree_gist/btree_utils_num.h')
0 files changed, 0 insertions, 0 deletions