diff options
author | Teodor Sigaev <teodor@sigaev.ru> | 2018-04-19 11:08:45 +0300 |
---|---|---|
committer | Teodor Sigaev <teodor@sigaev.ru> | 2018-04-19 11:08:45 +0300 |
commit | f97f0c921ae56bb16e466f3c9d6c504f4a96a539 (patch) | |
tree | 0bab985acf7a29d994b7d8fc4ce23ec052d74b2c | |
parent | 3d927961ae1232487796bebb254d92fb6d0d1e03 (diff) | |
download | postgresql-f97f0c921ae56bb16e466f3c9d6c504f4a96a539.tar.gz postgresql-f97f0c921ae56bb16e466f3c9d6c504f4a96a539.zip |
Adjust _bt_insertonpg() comments
Remove an obsolete reference to the 'afteritem' argument, which was
removed by commit bc292937. Add a comment that clarifies how
_bt_insertonpg() indirectly handles the insertion of high key items.
Author: Peter Geoghegan
-rw-r--r-- | src/backend/access/nbtree/nbtinsert.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index dbd5c9238c5..ecf4e53502a 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -817,18 +817,18 @@ _bt_findinsertloc(Relation rel, * insertion, and the buffer must be pinned and write-locked. On return, * we will have dropped both the pin and the lock on the buffer. * - * When inserting to a non-leaf page, 'cbuf' is the left-sibling of the - * page we're inserting the downlink for. This function will clear the + * This routine only performs retail tuple insertions. 'itup' should + * always be either a non-highkey leaf item, or a downlink (new high + * key items are created indirectly, when a page is split). When + * inserting to a non-leaf page, 'cbuf' is the left-sibling of the page + * we're inserting the downlink for. This function will clear the * INCOMPLETE_SPLIT flag on it, and release the buffer. * * The locking interactions in this code are critical. You should * grok Lehman and Yao's paper before making any changes. In addition, * you need to understand how we disambiguate duplicate keys in this * implementation, in order to be able to find our location using - * L&Y "move right" operations. Since we may insert duplicate user - * keys, and since these dups may propagate up the tree, we use the - * 'afteritem' parameter to position ourselves correctly for the - * insertion on internal pages. + * L&Y "move right" operations. *---------- */ static void |