diff options
| author | Bruce Momjian <bruce@momjian.us> | 2021-08-23 12:33:38 -0400 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2021-08-23 12:33:38 -0400 |
| commit | f7bda63a487c542949c8150de8e63bc728e5e31e (patch) | |
| tree | 7cc1cb5622e0869daa5ef130463ef6aa2abe74b0 | |
| parent | a3fcbcda7505e9079cec95e7209cde4f5d5c8bd8 (diff) | |
| download | postgresql-f7bda63a487c542949c8150de8e63bc728e5e31e.tar.gz postgresql-f7bda63a487c542949c8150de8e63bc728e5e31e.zip | |
Improve defaults shown in postgresql.conf.sample and pg_settings
Previously, these showed unlikely default values. The new default value
128MB (since PG 10) is not always accurate since initdb tries several
increasing values, but it likely to be accurate.
Reported-by: Zhangjie <zhangjie2@fujitsu.com>
Discussion: https://postgr.es/m/TYWPR01MB7678772FD8640C404F1DC882F9079@TYWPR01MB7678.jpnprd01.prod.outlook.com
Author: Zhangjie
Backpatch-through: master
| -rw-r--r-- | src/backend/utils/misc/guc.c | 2 | ||||
| -rw-r--r-- | src/backend/utils/misc/postgresql.conf.sample | 2 | ||||
| -rw-r--r-- | src/bin/initdb/initdb.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index a2e0f8de7e7..467b0fd6fe7 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2333,7 +2333,7 @@ static struct config_int ConfigureNamesInt[] = GUC_UNIT_BLOCKS }, &NBuffers, - 1024, 16, INT_MAX / 2, + 16384, 16, INT_MAX / 2, NULL, NULL, NULL }, diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index b242a7fc8b3..3fe9a53cb3f 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -124,7 +124,7 @@ # - Memory - -#shared_buffers = 32MB # min 128kB +#shared_buffers = 128MB # min 128kB # (change requires restart) #huge_pages = try # on, off, or try # (change requires restart) diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c index f05cddf0e08..a16ad026f32 100644 --- a/src/bin/initdb/initdb.c +++ b/src/bin/initdb/initdb.c @@ -1071,7 +1071,7 @@ setup_config(void) else snprintf(repltok, sizeof(repltok), "shared_buffers = %dkB", n_buffers * (BLCKSZ / 1024)); - conflines = replace_token(conflines, "#shared_buffers = 32MB", repltok); + conflines = replace_token(conflines, "#shared_buffers = 128MB", repltok); #ifdef HAVE_UNIX_SOCKETS snprintf(repltok, sizeof(repltok), "#unix_socket_directories = '%s'", |