diff options
| author | Andres Freund <andres@anarazel.de> | 2023-07-06 08:34:17 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2023-07-06 09:57:28 -0700 |
| commit | f0a94d81e4f7d3402d4b3a6b05b7b749ff23fe54 (patch) | |
| tree | 99136f4057c85fa9eedcc600554ff94f083375d7 | |
| parent | 1fa25ce70f0901b5b55b1fe9ca10cb3b9905db97 (diff) | |
| download | postgresql-f0a94d81e4f7d3402d4b3a6b05b7b749ff23fe54.tar.gz postgresql-f0a94d81e4f7d3402d4b3a6b05b7b749ff23fe54.zip | |
Fix type of iterator variable in SH_START_ITERATE
Also add comment to make the reasoning behind the Assert() more explicit (per
Tom).
Reported-by: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.com
Backpatch: 11-
| -rw-r--r-- | src/include/lib/simplehash.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/include/lib/simplehash.h b/src/include/lib/simplehash.h index 48db837ec8c..b7adc16b807 100644 --- a/src/include/lib/simplehash.h +++ b/src/include/lib/simplehash.h @@ -964,7 +964,6 @@ SH_DELETE_ITEM(SH_TYPE * tb, SH_ELEMENT_TYPE * entry) SH_SCOPE void SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter) { - int i; uint64 startelem = PG_UINT64_MAX; /* @@ -972,7 +971,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter) * supported, we want to start/end at an element that cannot be affected * by elements being shifted. */ - for (i = 0; i < tb->size; i++) + for (uint32 i = 0; i < tb->size; i++) { SH_ELEMENT_TYPE *entry = &tb->data[i]; @@ -983,6 +982,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter) } } + /* we should have found an empty element */ Assert(startelem < SH_MAX_SIZE); /* |