diff options
| author | David Rowley <drowley@postgresql.org> | 2024-05-14 12:39:30 +1200 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2024-05-14 12:39:30 +1200 |
| commit | ec1a405adc24bc20523eef83ccc85232ec23eaa9 (patch) | |
| tree | fadd48f5560707e325fbd431d78c489c05ad5c9e | |
| parent | 6961753381d8b2437195ce40d219a619a61002b6 (diff) | |
| download | postgresql-ec1a405adc24bc20523eef83ccc85232ec23eaa9.tar.gz postgresql-ec1a405adc24bc20523eef83ccc85232ec23eaa9.zip | |
Revert "Temporarily install debugging in partition_prune test"
1db689715 added debugging output to the partition_prune regression test
to help us figure out why buildfarm member Parula was occasionally
failing.
We've not seen any failures in around 4 weeks and the best guess as to
what the problem was is a compiler bug. Since there are no recent
failures, there's now no need to keep this debugging code, so revert it.
Discussion: https://postgr.es/m/CAApHDvqyLF881EvDtXT=ossa0i4ioJBtW2c0Wbouzt5d3HDb5Q@mail.gmail.com
| -rw-r--r-- | src/test/regress/expected/partition_prune.out | 62 | ||||
| -rw-r--r-- | src/test/regress/sql/partition_prune.sql | 14 |
2 files changed, 0 insertions, 76 deletions
diff --git a/src/test/regress/expected/partition_prune.out b/src/test/regress/expected/partition_prune.out index 46b78ba3c41..7ca98397aec 100644 --- a/src/test/regress/expected/partition_prune.out +++ b/src/test/regress/expected/partition_prune.out @@ -2449,37 +2449,6 @@ create index ab_a3_b3_a_idx on ab_a3_b3 (a); set enable_hashjoin = 0; set enable_mergejoin = 0; set enable_memoize = 0; --- Temporarily install some debugging to investigate plan instability. -select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count -from pg_class c -left join pg_stat_all_tables s on c.oid = s.relid -left join pg_index i on c.oid = i.indexrelid -where c.relname like 'ab\_%' order by c.relname; - relname | relpages | reltuples | indisvalid | autovacuum_count | autoanalyze_count -----------------+----------+-----------+------------+------------------+------------------- - ab_a1 | 0 | -1 | | 0 | 0 - ab_a1_b1 | 0 | -1 | | 0 | 0 - ab_a1_b1_a_idx | 1 | 0 | t | | - ab_a1_b2 | 0 | -1 | | 0 | 0 - ab_a1_b2_a_idx | 1 | 0 | t | | - ab_a1_b3 | 0 | -1 | | 0 | 0 - ab_a1_b3_a_idx | 1 | 0 | t | | - ab_a2 | 0 | -1 | | 0 | 0 - ab_a2_b1 | 0 | -1 | | 0 | 0 - ab_a2_b1_a_idx | 1 | 0 | t | | - ab_a2_b2 | 0 | -1 | | 0 | 0 - ab_a2_b2_a_idx | 1 | 0 | t | | - ab_a2_b3 | 0 | -1 | | 0 | 0 - ab_a2_b3_a_idx | 1 | 0 | t | | - ab_a3 | 0 | -1 | | 0 | 0 - ab_a3_b1 | 0 | -1 | | 0 | 0 - ab_a3_b1_a_idx | 1 | 0 | t | | - ab_a3_b2 | 0 | -1 | | 0 | 0 - ab_a3_b2_a_idx | 1 | 0 | t | | - ab_a3_b3 | 0 | -1 | | 0 | 0 - ab_a3_b3_a_idx | 1 | 0 | t | | -(21 rows) - select explain_parallel_append('select avg(ab.a) from ab inner join lprt_a a on ab.a = a.a where a.a in(0, 0, 1)'); explain_parallel_append -------------------------------------------------------------------------------------------------------- @@ -2855,37 +2824,6 @@ deallocate ab_q3; deallocate ab_q4; deallocate ab_q5; deallocate ab_q6; --- Temporarily install some debugging to investigate plan instability. -select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count -from pg_class c -left join pg_stat_all_tables s on c.oid = s.relid -left join pg_index i on c.oid = i.indexrelid -where c.relname like 'ab\_%' order by c.relname; - relname | relpages | reltuples | indisvalid | autovacuum_count | autoanalyze_count -----------------+----------+-----------+------------+------------------+------------------- - ab_a1 | 0 | -1 | | 0 | 0 - ab_a1_b1 | 0 | -1 | | 0 | 0 - ab_a1_b1_a_idx | 1 | 0 | t | | - ab_a1_b2 | 0 | -1 | | 0 | 0 - ab_a1_b2_a_idx | 1 | 0 | t | | - ab_a1_b3 | 0 | -1 | | 0 | 0 - ab_a1_b3_a_idx | 1 | 0 | t | | - ab_a2 | 0 | -1 | | 0 | 0 - ab_a2_b1 | 0 | -1 | | 0 | 0 - ab_a2_b1_a_idx | 1 | 0 | t | | - ab_a2_b2 | 0 | -1 | | 0 | 0 - ab_a2_b2_a_idx | 1 | 0 | t | | - ab_a2_b3 | 0 | -1 | | 0 | 0 - ab_a2_b3_a_idx | 1 | 0 | t | | - ab_a3 | 0 | -1 | | 0 | 0 - ab_a3_b1 | 0 | -1 | | 0 | 0 - ab_a3_b1_a_idx | 1 | 0 | t | | - ab_a3_b2 | 0 | -1 | | 0 | 0 - ab_a3_b2_a_idx | 1 | 0 | t | | - ab_a3_b3 | 0 | -1 | | 0 | 0 - ab_a3_b3_a_idx | 1 | 0 | t | | -(21 rows) - -- UPDATE on a partition subtree has been seen to have problems. insert into ab values (1,2); explain (analyze, costs off, summary off, timing off) diff --git a/src/test/regress/sql/partition_prune.sql b/src/test/regress/sql/partition_prune.sql index dc716938610..a09b27d820c 100644 --- a/src/test/regress/sql/partition_prune.sql +++ b/src/test/regress/sql/partition_prune.sql @@ -607,13 +607,6 @@ set enable_hashjoin = 0; set enable_mergejoin = 0; set enable_memoize = 0; --- Temporarily install some debugging to investigate plan instability. -select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count -from pg_class c -left join pg_stat_all_tables s on c.oid = s.relid -left join pg_index i on c.oid = i.indexrelid -where c.relname like 'ab\_%' order by c.relname; - select explain_parallel_append('select avg(ab.a) from ab inner join lprt_a a on ab.a = a.a where a.a in(0, 0, 1)'); -- Ensure the same partitions are pruned when we make the nested loop @@ -681,13 +674,6 @@ deallocate ab_q4; deallocate ab_q5; deallocate ab_q6; --- Temporarily install some debugging to investigate plan instability. -select c.relname,c.relpages,c.reltuples,i.indisvalid,s.autovacuum_count,s.autoanalyze_count -from pg_class c -left join pg_stat_all_tables s on c.oid = s.relid -left join pg_index i on c.oid = i.indexrelid -where c.relname like 'ab\_%' order by c.relname; - -- UPDATE on a partition subtree has been seen to have problems. insert into ab values (1,2); explain (analyze, costs off, summary off, timing off) |