diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-05-12 14:54:02 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-05-12 14:54:02 +0900 |
| commit | e6ccd1ce1644d1b40b7981f8bc172394de524f99 (patch) | |
| tree | 0ab17a7ae3d0047e7e59d440ae6e8c884dc66973 | |
| parent | ec6e70c79fffe9292402ee602d3742a8c7d31bd2 (diff) | |
| download | postgresql-e6ccd1ce1644d1b40b7981f8bc172394de524f99.tar.gz postgresql-e6ccd1ce1644d1b40b7981f8bc172394de524f99.zip | |
Simplify one use of ScanKey in pg_subscription.c
The section of the code in charge of returning all the relations
associated to a subscription only need one ScanKey, but allocated two of
them. This code was introduced as a copy-paste from a different area on
the same file by 7c4f524, making the result confusing to follow.
Author: Peter Smith
Reviewed-by: Tom Lane, Julien Rouhaud, Bharath Rupireddy
Discussion: https://postgr.es/m/CAHut+PsLKe+rN3FjchoJsd76rx2aMsFTB7CTFxRgUP05p=kcpQ@mail.gmail.com
| -rw-r--r-- | src/backend/catalog/pg_subscription.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/backend/catalog/pg_subscription.c b/src/backend/catalog/pg_subscription.c index 40397688651..7db1f7df08c 100644 --- a/src/backend/catalog/pg_subscription.c +++ b/src/backend/catalog/pg_subscription.c @@ -461,19 +461,18 @@ GetSubscriptionRelations(Oid subid) List *res = NIL; Relation rel; HeapTuple tup; - int nkeys = 0; - ScanKeyData skey[2]; + ScanKeyData skey[1]; SysScanDesc scan; rel = table_open(SubscriptionRelRelationId, AccessShareLock); - ScanKeyInit(&skey[nkeys++], + ScanKeyInit(&skey[0], Anum_pg_subscription_rel_srsubid, BTEqualStrategyNumber, F_OIDEQ, ObjectIdGetDatum(subid)); scan = systable_beginscan(rel, InvalidOid, false, - NULL, nkeys, skey); + NULL, 1, skey); while (HeapTupleIsValid(tup = systable_getnext(scan))) { |