diff options
| author | Michael Paquier <michael@paquier.xyz> | 2025-02-26 15:29:51 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2025-02-26 15:37:28 +0900 |
| commit | d7cbeaf261da346d8c745870da1d31075ae0313c (patch) | |
| tree | 7ce92606d4061c3255f9365731000ffc9175a8d2 | |
| parent | e117cfb2f6c67fe4ba46720bc6917da3dbd48c10 (diff) | |
| download | postgresql-d7cbeaf261da346d8c745870da1d31075ae0313c.tar.gz postgresql-d7cbeaf261da346d8c745870da1d31075ae0313c.zip | |
Remove pgstat_flush_wal()
All the processes that generate WAL should call pgstat_report_wal() to
report all their statistics related to WAL, and this is already what
happens in the tree. Keeping pgstat_report_wal() is confusing while the
other routine is encouraged.
This routine is not required since fc415edf8ca8, where it was lastly
used in pgstat_report_stat() before an equivalent callback existed.
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/Z71oPkJJICrRB5Ws@paquier.xyz
| -rw-r--r-- | src/backend/utils/activity/pgstat_wal.c | 11 | ||||
| -rw-r--r-- | src/include/utils/pgstat_internal.h | 2 |
2 files changed, 1 insertions, 12 deletions
diff --git a/src/backend/utils/activity/pgstat_wal.c b/src/backend/utils/activity/pgstat_wal.c index 4dc41a4a590..7beee2095a8 100644 --- a/src/backend/utils/activity/pgstat_wal.c +++ b/src/backend/utils/activity/pgstat_wal.c @@ -51,7 +51,7 @@ pgstat_report_wal(bool force) nowait = !force; /* flush wal stats */ - pgstat_flush_wal(nowait); + (void) pgstat_wal_flush_cb(nowait); /* flush IO stats */ pgstat_flush_io(nowait); @@ -70,15 +70,6 @@ pgstat_fetch_stat_wal(void) } /* - * Simple wrapper of pgstat_wal_flush_cb() - */ -void -pgstat_flush_wal(bool nowait) -{ - (void) pgstat_wal_flush_cb(nowait); -} - -/* * Calculate how much WAL usage counters have increased by subtracting the * previous counters from the current ones. * diff --git a/src/include/utils/pgstat_internal.h b/src/include/utils/pgstat_internal.h index 06dcea3f0dc..36d228e3558 100644 --- a/src/include/utils/pgstat_internal.h +++ b/src/include/utils/pgstat_internal.h @@ -748,8 +748,6 @@ extern void pgstat_slru_snapshot_cb(void); * Functions in pgstat_wal.c */ -extern void pgstat_flush_wal(bool nowait); - extern void pgstat_wal_init_backend_cb(void); extern bool pgstat_wal_have_pending_cb(void); extern bool pgstat_wal_flush_cb(bool nowait); |