aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-09-17 11:35:27 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-09-17 11:35:27 -0400
commitcad22075bc2ce9c1fbe61e8d3969d4dbdb5bc1f3 (patch)
tree0607efebef37f293c2f96ebf8e606792eab0b274
parent936df5ba80a46fb40bfc93da49a709cbc0aafe5e (diff)
downloadpostgresql-cad22075bc2ce9c1fbe61e8d3969d4dbdb5bc1f3.tar.gz
postgresql-cad22075bc2ce9c1fbe61e8d3969d4dbdb5bc1f3.zip
Fix bogus size calculation introduced by commit cc5f81366.
The elements of RecordCacheArray are TupleDesc, not TupleDesc *. Those are actually the same size, so that this error is harmless, but it's still wrong --- and it might bite us someday, if TupleDesc ever became a struct, say. Per Coverity.
-rw-r--r--src/backend/utils/cache/typcache.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/cache/typcache.c b/src/backend/utils/cache/typcache.c
index fd80c128cbe..16c52c5a38a 100644
--- a/src/backend/utils/cache/typcache.c
+++ b/src/backend/utils/cache/typcache.c
@@ -1386,7 +1386,7 @@ ensure_record_cache_typmod_slot_exists(int32 typmod)
RecordCacheArray = (TupleDesc *) repalloc(RecordCacheArray,
newlen * sizeof(TupleDesc));
memset(RecordCacheArray + RecordCacheArrayLen, 0,
- (newlen - RecordCacheArrayLen) * sizeof(TupleDesc *));
+ (newlen - RecordCacheArrayLen) * sizeof(TupleDesc));
RecordCacheArrayLen = newlen;
}
}