diff options
| author | Magnus Hagander <magnus@hagander.net> | 2012-02-21 17:12:25 +0100 |
|---|---|---|
| committer | Magnus Hagander <magnus@hagander.net> | 2012-02-21 17:12:25 +0100 |
| commit | c2a2f7516bd27d4b2bcd387b2aa25a5b98d9c7b0 (patch) | |
| tree | 747d52cb454d37deedfbca45b524f9254fe052f9 | |
| parent | 6b044cb810460993ad9e458a0ee8fcc9fde5a350 (diff) | |
| download | postgresql-c2a2f7516bd27d4b2bcd387b2aa25a5b98d9c7b0.tar.gz postgresql-c2a2f7516bd27d4b2bcd387b2aa25a5b98d9c7b0.zip | |
Avoid double close of file handle in syslogger on win32
This causes an exception when running under a debugger or in particular
when running on a debug version of Windows.
Patch from MauMau
| -rw-r--r-- | src/backend/postmaster/syslogger.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c index cea896a8f97..c331dd9de84 100644 --- a/src/backend/postmaster/syslogger.c +++ b/src/backend/postmaster/syslogger.c @@ -588,8 +588,11 @@ SysLogger_Start(void) errmsg("could not redirect stderr: %m"))); close(fd); _setmode(_fileno(stderr), _O_BINARY); - /* Now we are done with the write end of the pipe. */ - CloseHandle(syslogPipe[1]); + /* + * Now we are done with the write end of the pipe. + * CloseHandle() must not be called because the preceding + * close() closes the underlying handle. + */ syslogPipe[1] = 0; #endif redirection_done = true; |