diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-08-11 18:55:32 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-08-11 18:55:32 -0400 |
| commit | b43f7c117e667fb51df36ca62e6c86054b0f8d03 (patch) | |
| tree | 0da7950558eccd6ae1067eee44bb163c0d043a41 | |
| parent | d54ceb9e176152f930e60709e07c636e8e5414f5 (diff) | |
| download | postgresql-b43f7c117e667fb51df36ca62e6c86054b0f8d03.tar.gz postgresql-b43f7c117e667fb51df36ca62e6c86054b0f8d03.zip | |
Partially revert "Insert temporary debugging output in regression tests."
This reverts much of commit f03a9ca4366d064d89b7cf7ed75d4e43f2ed0667,
but leaves the relpages/reltuples probe in select_parallel.sql.
The pg_stat_all_tables probes are unstable enough to be annoying,
and it no longer seems likely that they will teach us anything more
about the underlying problem. I'd still like some more confirmation
though that the observed plan instability is caused by VACUUM leaving
relpages/reltuples as zero for one of these tables.
Discussion: https://postgr.es/m/CA+hUKG+0CxrKRWRMf5ymN3gm+BECHna2B-q1w8onKBep4HasUw@mail.gmail.com
| -rw-r--r-- | src/test/regress/expected/select_parallel.out | 13 | ||||
| -rw-r--r-- | src/test/regress/expected/stats.out | 27 | ||||
| -rw-r--r-- | src/test/regress/sql/select_parallel.sql | 3 | ||||
| -rw-r--r-- | src/test/regress/sql/stats.sql | 8 |
4 files changed, 0 insertions, 51 deletions
diff --git a/src/test/regress/expected/select_parallel.out b/src/test/regress/expected/select_parallel.out index 9775cc898ce..04aecef0123 100644 --- a/src/test/regress/expected/select_parallel.out +++ b/src/test/regress/expected/select_parallel.out @@ -103,19 +103,6 @@ where relname like '__star' order by relname; f_star | 1 | 16 (6 rows) -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count ----------+--------------+---------------+------------------+------------------- - a_star | 1 | 0 | 0 | 0 - b_star | 1 | 0 | 0 | 0 - c_star | 1 | 0 | 0 | 0 - d_star | 1 | 0 | 0 | 0 - e_star | 1 | 0 | 0 | 0 - f_star | 1 | 0 | 0 | 0 -(6 rows) - -- Disable Parallel Append alter table a_star reset (parallel_workers); alter table b_star reset (parallel_workers); diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index 61fbf7e41ea..b01e58b98cb 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -199,33 +199,6 @@ FROM prevstats AS pr; t (1 row) --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; - relname | relpages | reltuples ----------+----------+----------- - a_star | 1 | 3 - b_star | 1 | 4 - c_star | 1 | 4 - d_star | 1 | 16 - e_star | 1 | 7 - f_star | 1 | 16 -(6 rows) - -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count ----------+--------------+---------------+------------------+------------------- - a_star | 1 | 0 | 0 | 0 - b_star | 1 | 0 | 0 | 0 - c_star | 1 | 0 | 0 | 0 - d_star | 1 | 0 | 0 | 0 - e_star | 1 | 0 | 0 | 0 - f_star | 1 | 0 | 0 | 0 -(6 rows) - DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4; DROP TABLE prevstats; -- End of Stats Test diff --git a/src/test/regress/sql/select_parallel.sql b/src/test/regress/sql/select_parallel.sql index f96812b5506..2c056618ea5 100644 --- a/src/test/regress/sql/select_parallel.sql +++ b/src/test/regress/sql/select_parallel.sql @@ -40,9 +40,6 @@ select round(avg(aa)), sum(aa) from a_star a3; select relname, relpages, reltuples from pg_class where relname like '__star' order by relname; -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; -- Disable Parallel Append alter table a_star reset (parallel_workers); diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql index 9defd4b7a97..feaaee6326e 100644 --- a/src/test/regress/sql/stats.sql +++ b/src/test/regress/sql/stats.sql @@ -174,14 +174,6 @@ SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages, SELECT pr.snap_ts < pg_stat_get_snapshot_timestamp() as snapshot_newer FROM prevstats AS pr; --- Temporary hack to investigate whether extra vacuum/analyze is happening -select relname, relpages, reltuples -from pg_class -where relname like '__star' order by relname; -select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count -from pg_stat_all_tables -where relname like '__star' order by relname; - DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4; DROP TABLE prevstats; -- End of Stats Test |