aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Eisentraut <peter_e@gmx.net>2018-02-22 15:13:57 -0500
committerPeter Eisentraut <peter_e@gmx.net>2018-02-22 15:13:57 -0500
commitabcba7001e481a565b8fba2393666dc54e90db61 (patch)
treefe07b5c603daea79fd769e215dd0530f7d78bad5
parent0db2fc98cdf4135f9dcfa3740db6f2548682fe7e (diff)
downloadpostgresql-abcba7001e481a565b8fba2393666dc54e90db61.tar.gz
postgresql-abcba7001e481a565b8fba2393666dc54e90db61.zip
Fix perlcritic warnings
-rw-r--r--src/bin/pgbench/t/001_pgbench_with_server.pl8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
index 99286f6bc0c..e585220dc08 100644
--- a/src/bin/pgbench/t/001_pgbench_with_server.pl
+++ b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -584,7 +584,7 @@ sub check_pgbench_logs
{
my ($prefix, $nb, $min, $max, $re) = @_;
- my @logs = <$prefix.*>;
+ my @logs = glob "$prefix.*";
ok(@logs == $nb, "number of log files");
ok(grep(/^$prefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format");
@@ -592,14 +592,14 @@ sub check_pgbench_logs
for my $log (sort @logs)
{
eval {
- open LOG, $log or die "$@";
- my @contents = <LOG>;
+ open my $fh, '<', $log or die "$@";
+ my @contents = <$fh>;
my $clen = @contents;
ok( $min <= $clen && $clen <= $max,
"transaction count for $log ($clen)");
ok( grep($re, @contents) == $clen,
"transaction format for $prefix");
- close LOG or die "$@";
+ close $fh or die "$@";
};
}
ok(unlink(@logs), "remove log files");