diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-10-25 10:34:27 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-10-25 10:34:27 +0900 |
| commit | 9f00edc2288892a55e2bef464f555e9f5396ff1c (patch) | |
| tree | 86d0f68be0c7c13c5d612fab5392511c9fea0b24 | |
| parent | ffe12d1d22e73d7bcda1f0ee9af33d04fab199b2 (diff) | |
| download | postgresql-9f00edc2288892a55e2bef464f555e9f5396ff1c.tar.gz postgresql-9f00edc2288892a55e2bef464f555e9f5396ff1c.zip | |
injection_points: Disable one permutation in isolation test "basic"
The first permutation done in the test does a wait, a wakeup then a
detach. It is proving to be unstable in the CI for FreeBSD (Windows and
Linux are stable). The failure shows that the wait is so slow to finish
after being woken up that the detach has the time to finish before the
wait, messing up with the expected output.
There may be a platform-specific issue going on here, but for now
disable this permutation to make the CI runs more stable.
Discussion: https://postgr.es/m/ZxrnSGdNtQWAxE3_@paquier.xyz
| -rw-r--r-- | src/test/modules/injection_points/expected/basic.out | 26 | ||||
| -rw-r--r-- | src/test/modules/injection_points/specs/basic.spec | 3 |
2 files changed, 2 insertions, 27 deletions
diff --git a/src/test/modules/injection_points/expected/basic.out b/src/test/modules/injection_points/expected/basic.out index 840ce2dac90..9499ef4bd9d 100644 --- a/src/test/modules/injection_points/expected/basic.out +++ b/src/test/modules/injection_points/expected/basic.out @@ -1,31 +1,5 @@ Parsed test spec with 2 sessions -starting permutation: wait1 wakeup2 detach2 -injection_points_attach ------------------------ - -(1 row) - -step wait1: SELECT injection_points_run('injection-points-wait'); <waiting ...> -step wakeup2: SELECT injection_points_wakeup('injection-points-wait'); -injection_points_wakeup ------------------------ - -(1 row) - -step wait1: <... completed> -injection_points_run --------------------- - -(1 row) - -step detach2: SELECT injection_points_detach('injection-points-wait'); -injection_points_detach ------------------------ - -(1 row) - - starting permutation: wait1 detach2 wakeup2 injection_points_attach ----------------------- diff --git a/src/test/modules/injection_points/specs/basic.spec b/src/test/modules/injection_points/specs/basic.spec index 7c50d85e1f9..7f44e3ddc35 100644 --- a/src/test/modules/injection_points/specs/basic.spec +++ b/src/test/modules/injection_points/specs/basic.spec @@ -26,7 +26,8 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); } step detach2 { SELECT injection_points_detach('injection-points-wait'); } # Detach after wait and wakeup. -permutation wait1 wakeup2 detach2 +# This permutation is proving to be unstable on FreeBSD, so disable for now. +#permutation wait1 wakeup2 detach2 # Detach before wakeup. s1 waits until wakeup, ignores the detach. permutation wait1 detach2 wakeup2 |