aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEtsuro Fujita <efujita@postgresql.org>2021-10-07 18:15:00 +0900
committerEtsuro Fujita <efujita@postgresql.org>2021-10-07 18:15:00 +0900
commit972c7c6567fbb02a59b94ede80b17805de1bc03c (patch)
tree5142c365a8dfd631fbb28ba60341ab0c3e771612
parent700c73312841bd1a89263f238556ce8d8d916258 (diff)
downloadpostgresql-972c7c6567fbb02a59b94ede80b17805de1bc03c.tar.gz
postgresql-972c7c6567fbb02a59b94ede80b17805de1bc03c.zip
postgres_fdw: Fix comments in connection.c.
Commit 27e1f1456 missed updating some comments. Reviewed-by: Bharath Rupireddy Backpatch-through: 14 Discussion: https://postgr.es/m/CAPmGK15Q2Nm6U%2Ba_GwskrWFEVBZ9_3VKOvRrprGufpx91M_3Sw%40mail.gmail.com
-rw-r--r--contrib/postgres_fdw/connection.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
index 1e67da983cb..ce0164e9d23 100644
--- a/contrib/postgres_fdw/connection.c
+++ b/contrib/postgres_fdw/connection.c
@@ -197,9 +197,9 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
make_new_connection(entry, user);
/*
- * We check the health of the cached connection here when starting a new
- * remote transaction. If a broken connection is detected, we try to
- * reestablish a new connection later.
+ * We check the health of the cached connection here when using it. In
+ * cases where we're out of all transactions, if a broken connection is
+ * detected, we try to reestablish a new connection later.
*/
PG_TRY();
{
@@ -215,9 +215,7 @@ GetConnection(UserMapping *user, bool will_prep_stmt, PgFdwConnState **state)
ErrorData *errdata = CopyErrorData();
/*
- * If connection failure is reported when starting a new remote
- * transaction (not subtransaction), new connection will be
- * reestablished later.
+ * Determine whether to try to reestablish the connection.
*
* After a broken connection is detected in libpq, any error other
* than connection failure (e.g., out-of-memory) can be thrown