diff options
| author | Etsuro Fujita <efujita@postgresql.org> | 2019-12-16 17:00:15 +0900 |
|---|---|---|
| committer | Etsuro Fujita <efujita@postgresql.org> | 2019-12-16 17:00:15 +0900 |
| commit | 956ef5875341c22a602fb825e6c98eaabb1ecce7 (patch) | |
| tree | 7dc6acd33f55b8b3b17fb4f05fc6eab222f4930b | |
| parent | e5a02e0fc68bd57048f2c74a89f5412dbf87015e (diff) | |
| download | postgresql-956ef5875341c22a602fb825e6c98eaabb1ecce7.tar.gz postgresql-956ef5875341c22a602fb825e6c98eaabb1ecce7.zip | |
Clean up some misplaced comments in partition_join.sql regression test.
Also, add a comment explaining a test case.
Back-patch to 11 where the regression test was added.
Discussion: https://postgr.es/m/CAPmGK15adZPh2B%2BmGUjSOMH%2BH39ogDRWfCfm4G6jncZCAs9V_Q%40mail.gmail.com
| -rw-r--r-- | src/test/regress/expected/partition_join.out | 10 | ||||
| -rw-r--r-- | src/test/regress/sql/partition_join.sql | 11 |
2 files changed, 13 insertions, 8 deletions
diff --git a/src/test/regress/expected/partition_join.out b/src/test/regress/expected/partition_join.out index 8e475bf4492..b3fbe47bde0 100644 --- a/src/test/regress/expected/partition_join.out +++ b/src/test/regress/expected/partition_join.out @@ -1996,8 +1996,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_m t1 LEFT JOIN prt2_m t2 ON t1.c = t2.c; -> Seq Scan on prt2_m_p3 t2_3 (11 rows) --- partitionwise join can not be applied between tables with different --- partition lists +-- partitionwise join can not be applied for a join between list and range +-- partitioned tables EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 LEFT JOIN prt2_n t2 ON (t1.c = t2.c); QUERY PLAN @@ -2013,6 +2013,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 LEFT JOIN prt2_n t2 ON (t1.c = t2.c -> Seq Scan on prt1_n_p2 t1_2 (9 rows) +-- partitionwise join can not be applied between tables with different +-- partition lists EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 JOIN prt2_n t2 ON (t1.c = t2.c) JOIN plt1 t3 ON (t1.c = t3.c); QUERY PLAN @@ -2035,8 +2037,8 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 JOIN prt2_n t2 ON (t1.c = t2.c) JOI -> Seq Scan on prt1_n_p2 t1_2 (16 rows) --- partitionwise join can not be applied for a join between list and range --- partitioned tables +-- partitionwise join can not be applied for a join between key column and +-- non-key column EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 FULL JOIN prt1 t2 ON (t1.c = t2.c); QUERY PLAN diff --git a/src/test/regress/sql/partition_join.sql b/src/test/regress/sql/partition_join.sql index 92994b479bb..575ba7b8d4f 100644 --- a/src/test/regress/sql/partition_join.sql +++ b/src/test/regress/sql/partition_join.sql @@ -430,15 +430,18 @@ SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_m t1 LEFT JOIN prt2_m t2 ON t1.a = t2.b; EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_m t1 LEFT JOIN prt2_m t2 ON t1.c = t2.c; --- partitionwise join can not be applied between tables with different --- partition lists +-- partitionwise join can not be applied for a join between list and range +-- partitioned tables EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 LEFT JOIN prt2_n t2 ON (t1.c = t2.c); + +-- partitionwise join can not be applied between tables with different +-- partition lists EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 JOIN prt2_n t2 ON (t1.c = t2.c) JOIN plt1 t3 ON (t1.c = t3.c); --- partitionwise join can not be applied for a join between list and range --- partitioned tables +-- partitionwise join can not be applied for a join between key column and +-- non-key column EXPLAIN (COSTS OFF) SELECT t1.a, t1.c, t2.b, t2.c FROM prt1_n t1 FULL JOIN prt1 t2 ON (t1.c = t2.c); |