diff options
| author | Bruce Momjian <bruce@momjian.us> | 2013-01-22 22:27:13 -0500 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2013-01-22 22:27:16 -0500 |
| commit | 861ad67bd9546a8328ea31d0141406db16f4c57c (patch) | |
| tree | 75eb2f62ce3aabba7e7e30382143225706975205 | |
| parent | 21c87a0d46c8e9eb299d0fdfb75728c931452ddb (diff) | |
| download | postgresql-861ad67bd9546a8328ea31d0141406db16f4c57c.tar.gz postgresql-861ad67bd9546a8328ea31d0141406db16f4c57c.zip | |
pg_upgrade: remove --single-transaction usage
With AtEOXact applied, --single-transaction makes pg_restore slower, and
has the potential to require lock table configuration, so remove the
argument.
Per suggestion from Tom.
| -rw-r--r-- | contrib/pg_upgrade/pg_upgrade.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c index 85997e59bf7..88494b8d6de 100644 --- a/contrib/pg_upgrade/pg_upgrade.c +++ b/contrib/pg_upgrade/pg_upgrade.c @@ -314,12 +314,11 @@ create_new_objects(void) snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid); /* - * Using pg_restore --single-transaction is faster than other - * methods, like --jobs. pg_dump only produces its output at the - * end, so there is little parallelism using the pipe. + * pg_dump only produces its output at the end, so there is little + * parallelism if using the pipe. */ parallel_exec_prog(log_file_name, NULL, - "\"%s/pg_restore\" %s --exit-on-error --single-transaction --verbose --dbname \"%s\" \"%s\"", + "\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"", new_cluster.bindir, cluster_conn_opts(&new_cluster), old_db->db_name, sql_file_name); } |