aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Gustafsson <dgustafsson@postgresql.org>2024-04-08 00:24:20 +0200
committerDaniel Gustafsson <dgustafsson@postgresql.org>2024-04-08 00:24:20 +0200
commit75a47b6a0dc4a235307e1acd1a6b3845cb881e55 (patch)
treedfdef4c6b828ed09fca16f3d888dd9c90b11a202
parent626603d46337ee331d7616b34ae539b1195556a7 (diff)
downloadpostgresql-75a47b6a0dc4a235307e1acd1a6b3845cb881e55.tar.gz
postgresql-75a47b6a0dc4a235307e1acd1a6b3845cb881e55.zip
Change debug printing to log filename
When restarting the cluster fails the code introduced in 33774978c78 printed the full log contents to aid debugging. For cases when the logfile is large this adds unnecessary overhead. Reduce to printing the logfile path instead. Reported-by: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20240406214439.2n4zf2w7ukhf7dsy@awork3.anarazel.de
-rw-r--r--src/test/perl/PostgreSQL/Test/Cluster.pm8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
index 54e1008ae58..9b2879c145c 100644
--- a/src/test/perl/PostgreSQL/Test/Cluster.pm
+++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -951,8 +951,8 @@ sub start
if ($ret != 0)
{
- print "# pg_ctl start failed; logfile:\n";
- print PostgreSQL::Test::Utils::slurp_file($self->logfile);
+ print "# pg_ctl start failed; see logfile for details: "
+ . $self->logfile . "\n";
# pg_ctl could have timed out, so check to see if there's a pid file;
# otherwise our END block will fail to shut down the new postmaster.
@@ -1090,8 +1090,8 @@ sub restart
if ($ret != 0)
{
- print "# pg_ctl restart failed; logfile:\n";
- print PostgreSQL::Test::Utils::slurp_file($self->logfile);
+ print "# pg_ctl restart failed; see logfile for details: "
+ . $self->logfile . "\n";
# pg_ctl could have timed out, so check to see if there's a pid file;
# otherwise our END block will fail to shut down the new postmaster.