diff options
| author | Michael Paquier <michael@paquier.xyz> | 2022-10-13 08:53:42 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2022-10-13 08:53:42 +0900 |
| commit | 63585b1ebd0d5ee66ff8f801202656d40ff9bb63 (patch) | |
| tree | 42af9ce9ddb4886eaadfa7571ed484cf1ba00237 | |
| parent | 2d27e13b35e9a932006006eb084cf9a1d90a8cb8 (diff) | |
| download | postgresql-63585b1ebd0d5ee66ff8f801202656d40ff9bb63.tar.gz postgresql-63585b1ebd0d5ee66ff8f801202656d40ff9bb63.zip | |
doc: Fix description of replication command CREATE_REPLICATION_SLOT
The output plugin name is a mandatory option when creating a logical
slot, but the grammar documented was not described as such. While on
it, fix two comments in repl_gram.y to show that TEMPORARY is an
optional grammar choice.
Author: Ayaki Tachikake
Discussion: https://postgr.es/m/OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com
Backpatch-through: 15
| -rw-r--r-- | doc/src/sgml/protocol.sgml | 2 | ||||
| -rw-r--r-- | src/backend/replication/repl_gram.y | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 75caa7fdb67..5fdd429e05d 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -1987,7 +1987,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;" </varlistentry> <varlistentry id="protocol-replication-create-replication-slot" xreflabel="CREATE_REPLICATION_SLOT"> - <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] + <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [ <literal>TEMPORARY</literal> ] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> <replaceable class="parameter">output_plugin</replaceable> } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] <indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm> </term> <listitem> diff --git a/src/backend/replication/repl_gram.y b/src/backend/replication/repl_gram.y index fe1ec2bc810..7ba33d6672f 100644 --- a/src/backend/replication/repl_gram.y +++ b/src/backend/replication/repl_gram.y @@ -172,7 +172,7 @@ base_backup: ; create_replication_slot: - /* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */ + /* CREATE_REPLICATION_SLOT slot [TEMPORARY] PHYSICAL [options] */ K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options { CreateReplicationSlotCmd *cmd; @@ -183,7 +183,7 @@ create_replication_slot: cmd->options = $5; $$ = (Node *) cmd; } - /* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */ + /* CREATE_REPLICATION_SLOT slot [TEMPORARY] LOGICAL plugin [options] */ | K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT create_slot_options { CreateReplicationSlotCmd *cmd; |