aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2025-05-10 07:36:27 -0700
committerNoah Misch <noah@leadboat.com>2025-05-10 07:36:27 -0700
commit4a4ee0c2c1e53401924101945ac3d517c0a8a559 (patch)
tree226bcf4055af067fedb10649e13064d826ca427e
parent99ddf8615c215bb81655574b9a9f7e8ebb2cb89e (diff)
downloadpostgresql-4a4ee0c2c1e53401924101945ac3d517c0a8a559.tar.gz
postgresql-4a4ee0c2c1e53401924101945ac3d517c0a8a559.zip
Remove GLOBALTABLESPACE_OID assert for locked buffers.
Commit f4ece891fc2f3f96f0571720a1ae30db8030681b added the assertion in an attempt to catch some defects even after VACUUM FULL or REINDEX. However, IsCatalogTextUniqueIndexOid(tag.relNumber) always returns false after a relfilenode change, provoking unintended assertion failures. Reported-by: Adam Guo <adamguo@amazon.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Bug: #18912 Discussion: https://postgr.es/m/18912-a41c9bd0e0ad19b1@postgresql.org
-rw-r--r--src/backend/storage/buffer/bufmgr.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 0b317d2d809..f93131a645e 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -4161,8 +4161,6 @@ AssertNotCatalogBufferLock(LWLock *lock, LWLockMode mode,
return;
Assert(!IsCatalogRelationOid(relid));
- /* Shared rels are always catalogs: detect even after VACUUM FULL. */
- Assert(tag.spcOid != GLOBALTABLESPACE_OID);
}
#endif