diff options
| author | Bruce Momjian <bruce@momjian.us> | 2011-07-21 17:12:35 -0400 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2011-07-21 17:13:17 -0400 |
| commit | 43aa40e1551b9e8d30b376de6d6a9b976ae54332 (patch) | |
| tree | f90c3fc9df26abb9dfcf2d7cd3e0e9db5efa0364 | |
| parent | a9f0dbc39df88ea7672352d3e7070d2603491bec (diff) | |
| download | postgresql-43aa40e1551b9e8d30b376de6d6a9b976ae54332.tar.gz postgresql-43aa40e1551b9e8d30b376de6d6a9b976ae54332.zip | |
In pg_upgrade, add C comment about why we don't try to do shared file
writes for logging.
| -rw-r--r-- | contrib/pg_upgrade/pg_upgrade.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h index df884bd684b..6def748ae81 100644 --- a/contrib/pg_upgrade/pg_upgrade.h +++ b/contrib/pg_upgrade/pg_upgrade.h @@ -207,6 +207,10 @@ typedef struct * because it is being used by another process." so we have to send all * other output to 'nul'. Therefore, we set this to DEVNULL on Win32, and * it equals 'filename' on all other platforms. + * + * We could use the Windows pgwin32_open() flags to allow shared file + * writes but is unclear how all other tools would use those flags, so + * we just avoid it and log a little less on Windows. */ char *filename2; FILE *fd; /* log FILE */ |