diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-04-19 23:03:59 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-04-19 23:03:59 -0400 |
| commit | 344a225cb9d42f20df063e4d0e0d4559c5de7910 (patch) | |
| tree | 9e446d6523e67cfa7271f9b2e4160a032723909d | |
| parent | 83cca409edf276cfbd2ff691ceea1b10027c5205 (diff) | |
| download | postgresql-344a225cb9d42f20df063e4d0e0d4559c5de7910.tar.gz postgresql-344a225cb9d42f20df063e4d0e0d4559c5de7910.zip | |
Fix breakage in AlterFunction().
An ALTER FUNCTION command that tried to update both the function's
proparallel property and its proconfig list failed to do the former,
because it stored the new proparallel value into a tuple that was
no longer the interesting one. Carelessness in 7aea8e4f2.
(I did not bother with a regression test, because the only likely
future breakage would be for someone to ignore the comment I added
and add some other field update after the heap_modify_tuple step.
A test using existing function properties could not catch that.)
Per report from Bryn Llewellyn. Back-patch to all supported branches.
Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com
| -rw-r--r-- | src/backend/commands/functioncmds.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c index 91f02a7eb2c..00a6d282cfd 100644 --- a/src/backend/commands/functioncmds.c +++ b/src/backend/commands/functioncmds.c @@ -1472,6 +1472,8 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt) procForm->prosupport = newsupport; } + if (parallel_item) + procForm->proparallel = interpret_func_parallel(parallel_item); if (set_items) { Datum datum; @@ -1506,8 +1508,7 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt) tup = heap_modify_tuple(tup, RelationGetDescr(rel), repl_val, repl_null, repl_repl); } - if (parallel_item) - procForm->proparallel = interpret_func_parallel(parallel_item); + /* DO NOT put more touches of procForm below here; it's now dangling. */ /* Do the update */ CatalogTupleUpdate(rel, &tup->t_self, tup); |