diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2023-04-08 15:51:45 +0200 |
|---|---|---|
| committer | Daniel Gustafsson <dgustafsson@postgresql.org> | 2023-04-08 15:51:45 +0200 |
| commit | 2e57ffe12f6b5c1498f29cb7c0d9e17c797d9da6 (patch) | |
| tree | 65ab1fcfc860cbc3d360204bfa250442077a97a6 | |
| parent | 0e9b271890c09ecb60b08e45d377031b2385ebeb (diff) | |
| download | postgresql-2e57ffe12f6b5c1498f29cb7c0d9e17c797d9da6.tar.gz postgresql-2e57ffe12f6b5c1498f29cb7c0d9e17c797d9da6.zip | |
Skip \password TAP test on old IPC::Run versions
IPC::Run versions prior to 0.98 cause the interactive session to time out,
so SKIP the test in case these versions are detected (they are within the
base requirement for our TAP tests in general). Error reported by the BF
and investigation by Tom Lane.
Discussion: https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se
| -rw-r--r-- | src/test/authentication/t/001_password.pl | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/test/authentication/t/001_password.pl b/src/test/authentication/t/001_password.pl index f414a8ba904..10ebe014d69 100644 --- a/src/test/authentication/t/001_password.pl +++ b/src/test/authentication/t/001_password.pl @@ -102,10 +102,12 @@ my $res = $node->safe_psql('postgres', is($res, 'SCRAM-SHA-256$1024:', 'scram_iterations in server side ROLE'); # If we don't have IO::Pty, forget it, because IPC::Run depends on that -# to support pty connections +# to support pty connections. Also skip if IPC::Run isn't at least 0.98 +# as earlier version cause the session to time out. SKIP: { - skip "IO::Pty required", 1 unless eval { require IO::Pty; }; + skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless + (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' }); # Alter the password on the created role using \password in psql to ensure # that clientside password changes use the scram_iterations value when |