aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2013-01-13 18:50:48 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2013-01-13 18:50:48 -0500
commit24dd0502a106102d81782de4966c476fd0ab2efa (patch)
tree9afcb85c3c47ae737130ac1b72606c840a611d47
parentb853eb97182079dcd30b4f52576bd5d6c275ee71 (diff)
downloadpostgresql-24dd0502a106102d81782de4966c476fd0ab2efa.tar.gz
postgresql-24dd0502a106102d81782de4966c476fd0ab2efa.zip
Update comments for elog_start().
Forgot I was going to do this as part of the previous patch ...
-rw-r--r--src/backend/utils/error/elog.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index e710f227812..1db62eb1b0b 100644
--- a/src/backend/utils/error/elog.c
+++ b/src/backend/utils/error/elog.c
@@ -1156,12 +1156,13 @@ getinternalerrposition(void)
* elog_start --- startup for old-style API
*
* All that we do here is stash the hidden filename/lineno/funcname
- * arguments into a stack entry.
+ * arguments into a stack entry, along with the current value of errno.
*
* We need this to be separate from elog_finish because there's no other
- * portable way to deal with inserting extra arguments into the elog call.
- * (If macros with variable numbers of arguments were portable, it'd be
- * easy, but they aren't.)
+ * C89-compliant way to deal with inserting extra arguments into the elog
+ * call. (When using C99's __VA_ARGS__, we could possibly merge this with
+ * elog_finish, but there doesn't seem to be a good way to save errno before
+ * evaluating the format arguments if we do that.)
*/
void
elog_start(const char *filename, int lineno, const char *funcname)