aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Haas <rhaas@postgresql.org>2020-04-03 15:40:35 -0400
committerRobert Haas <rhaas@postgresql.org>2020-04-03 15:40:35 -0400
commit21dc48840c24e70b1b1f0f6478f3dba5343182dd (patch)
tree9126a7a07b7814e6af2107886cf82f9c10bdd815
parent87e300434058a157bbc4ef8d039937abdefa7610 (diff)
downloadpostgresql-21dc48840c24e70b1b1f0f6478f3dba5343182dd.tar.gz
postgresql-21dc48840c24e70b1b1f0f6478f3dba5343182dd.zip
pg_validatebackup: Use tempdir_short in TAP tests.
The buildfarm is very unhappy right now because TAP test 003_corruption.pl uses TestLib::tempdir to generate the name of a temporary directory that is used as a tablespace name, and this results in a 'symbolic link target too long' error message on many of the buildfarm machines, but not on my machine. It appears that other people have run into similar problems in the past and that TestLib::tempdir_short was the solution, so let's try using that instead.
-rw-r--r--src/bin/pg_validatebackup/t/003_corruption.pl4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bin/pg_validatebackup/t/003_corruption.pl b/src/bin/pg_validatebackup/t/003_corruption.pl
index 787fdde0044..0a1533bd61b 100644
--- a/src/bin/pg_validatebackup/t/003_corruption.pl
+++ b/src/bin/pg_validatebackup/t/003_corruption.pl
@@ -15,7 +15,7 @@ $master->start;
# Include a user-defined tablespace in the hopes of detecting problems in that
# area.
-my $source_ts_path = TestLib::tempdir;
+my $source_ts_path = TestLib::tempdir_short;
$master->safe_psql('postgres', <<EOM);
CREATE TABLE x1 (a int);
INSERT INTO x1 VALUES (111);
@@ -103,7 +103,7 @@ for my $scenario (@scenario)
# Take a backup and check that it validates OK.
my $backup_path = $master->backup_dir . '/' . $name;
- my $backup_ts_path = TestLib::tempdir;
+ my $backup_ts_path = TestLib::tempdir_short;
$master->command_ok(['pg_basebackup', '-D', $backup_path, '--no-sync',
'-T', "${source_ts_path}=${backup_ts_path}"],
"base backup ok");