diff options
| author | Andres Freund <andres@anarazel.de> | 2021-03-01 09:52:15 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2021-03-01 11:25:24 -0800 |
| commit | 1e6e40447115ca7b4749d7d117b81b016ee5e2c2 (patch) | |
| tree | f76c4b72e7b351303a247e2c61fa513c65824725 | |
| parent | f5a5773a9dc4185414fe538525e20d8512c2ba35 (diff) | |
| download | postgresql-1e6e40447115ca7b4749d7d117b81b016ee5e2c2.tar.gz postgresql-1e6e40447115ca7b4749d7d117b81b016ee5e2c2.zip | |
Fix recovery test hang in 021_row_visibility.pl on windows.
The psql processes were not explicitly killed (but would eventually
exit due postgres shutting down). For some reason windows perl doesn't
like that, resulting in errors like
Warning: unable to close filehandle GEN20 properly: Bad file descriptor during global destruction.
The test was introduced in d6734a897e3, so no backpatching necessary.
| -rw-r--r-- | src/test/recovery/t/021_row_visibility.pl | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/test/recovery/t/021_row_visibility.pl b/src/test/recovery/t/021_row_visibility.pl index fac6646a872..b76990dfe05 100644 --- a/src/test/recovery/t/021_row_visibility.pl +++ b/src/test/recovery/t/021_row_visibility.pl @@ -151,6 +151,10 @@ ok(send_query_and_wait(\%psql_standby, qr/will_commit.*\n\(1 row\)$/m), 'finished prepared visible'); +# explicitly shut down psql instances - they cause hangs on windows +$psql_primary{run}->kill_kill; +$psql_standby{run}->kill_kill; + $node_primary->stop; $node_standby->stop; |