diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-08-09 12:39:07 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-08-09 12:39:07 -0400 |
| commit | 1b9cde51246c7773eac119b84cc18095118735de (patch) | |
| tree | 6cfdf1e30c84567237a2b2e40587d1ce1695bfa7 | |
| parent | 1c164ef3d28dfab445a885a03e80cfd0d552f64a (diff) | |
| download | postgresql-1b9cde51246c7773eac119b84cc18095118735de.tar.gz postgresql-1b9cde51246c7773eac119b84cc18095118735de.zip | |
Check for fseeko() failure in pg_dump's _tarAddFile().
Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these. Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem. Still, that's a
poor excuse for not checking the result of a system call.
| -rw-r--r-- | src/bin/pg_dump/pg_backup_tar.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/bin/pg_dump/pg_backup_tar.c b/src/bin/pg_dump/pg_backup_tar.c index b4f59429592..c601ec07012 100644 --- a/src/bin/pg_dump/pg_backup_tar.c +++ b/src/bin/pg_dump/pg_backup_tar.c @@ -1082,11 +1082,13 @@ _tarAddFile(ArchiveHandle *AH, TAR_MEMBER *th) /* * Find file len & go back to start. */ - fseeko(tmp, 0, SEEK_END); + if (fseeko(tmp, 0, SEEK_END) != 0) + fatal("error during file seek: %m"); th->fileLen = ftello(tmp); if (th->fileLen < 0) fatal("could not determine seek position in archive file: %m"); - fseeko(tmp, 0, SEEK_SET); + if (fseeko(tmp, 0, SEEK_SET) != 0) + fatal("error during file seek: %m"); _tarWriteHeader(th); |