aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2016-12-02 17:23:54 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2016-12-02 17:23:54 -0500
commit19fcc0058ecc8e5eb756547006bc1b24a93cbb80 (patch)
tree88fde72bcf51f6d0cfcec3188192b04e16f9d6ae
parent767a9039d79e35c78afa39cf5ffa3b485a2e3a5b (diff)
downloadpostgresql-19fcc0058ecc8e5eb756547006bc1b24a93cbb80.tar.gz
postgresql-19fcc0058ecc8e5eb756547006bc1b24a93cbb80.zip
Fix broken wait-for-previous-process-to-exit loop in regression test.
Must do pg_stat_clear_snapshot() inside test's loop, or our snapshot of pg_stat_activity will never change :-(. Thinko in b3427dade -- evidently my workstation never really iterated the loop in testing. Per buildfarm.
-rw-r--r--src/test/modules/test_extensions/expected/test_extensions.out2
-rw-r--r--src/test/modules/test_extensions/sql/test_extensions.sql2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/test/modules/test_extensions/expected/test_extensions.out b/src/test/modules/test_extensions/expected/test_extensions.out
index a24820e7359..ba8b90e7426 100644
--- a/src/test/modules/test_extensions/expected/test_extensions.out
+++ b/src/test/modules/test_extensions/expected/test_extensions.out
@@ -106,7 +106,7 @@ do 'declare c int = 0;
begin
while (select count(*) from pg_stat_activity where pid = '
:'oldpid'
- ') > 0 loop c := c + 1; end loop;
+ ') > 0 loop c := c + 1; perform pg_stat_clear_snapshot(); end loop;
raise log ''test_extensions looped % times'', c;
end';
-- extension should now contain no temp objects
diff --git a/src/test/modules/test_extensions/sql/test_extensions.sql b/src/test/modules/test_extensions/sql/test_extensions.sql
index 5e884d187f3..0bfc5592953 100644
--- a/src/test/modules/test_extensions/sql/test_extensions.sql
+++ b/src/test/modules/test_extensions/sql/test_extensions.sql
@@ -55,7 +55,7 @@ do 'declare c int = 0;
begin
while (select count(*) from pg_stat_activity where pid = '
:'oldpid'
- ') > 0 loop c := c + 1; end loop;
+ ') > 0 loop c := c + 1; perform pg_stat_clear_snapshot(); end loop;
raise log ''test_extensions looped % times'', c;
end';