diff options
| author | Michael Paquier <michael@paquier.xyz> | 2019-05-13 09:11:50 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2019-05-13 09:11:50 +0900 |
| commit | 1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88 (patch) | |
| tree | 94d68bd4cacc4ba2ad00db9867ada63dd5190423 | |
| parent | 8a29ed05302ea18b4be177c2d1181b43706af45f (diff) | |
| download | postgresql-1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88.tar.gz postgresql-1171dbde2daef8f0dcd1dc1e54531a0d8dd34d88.zip | |
Fix incorrect return value in JSON equality function for scalars
equalsJsonbScalarValue() uses a boolean as return type, however for one
code path -1 gets returned, which is confusing. The origin of the
confusion is visibly that this code got copy-pasted from
compareJsonbScalarValue() since it has been introduced in d1d50bf.
No backpatch, as this is only cosmetic.
Author: Rikard Falkeborn
Discussion: https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com
| -rw-r--r-- | src/backend/utils/adt/jsonb_util.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c index 3b249fe8cb0..1a28d75c59b 100644 --- a/src/backend/utils/adt/jsonb_util.c +++ b/src/backend/utils/adt/jsonb_util.c @@ -1318,7 +1318,7 @@ equalsJsonbScalarValue(JsonbValue *aScalar, JsonbValue *bScalar) } } elog(ERROR, "jsonb scalar type mismatch"); - return -1; + return false; } /* |