aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorValentin Bartenev <vbart@nginx.com>2014-04-21 19:21:17 +0400
committerValentin Bartenev <vbart@nginx.com>2014-04-21 19:21:17 +0400
commitf79908af6e6e579ec8d1dd10bf54da65cb7bd769 (patch)
treedff5df339a5d4a72b4be5e2e4dc498af4a0279e6 /src
parenta57959b6cdc3729bc8e5bc380c6f47399720da6f (diff)
downloadnginx-f79908af6e6e579ec8d1dd10bf54da65cb7bd769.tar.gz
nginx-f79908af6e6e579ec8d1dd10bf54da65cb7bd769.zip
SPDY: avoid sending RST_STREAM on WINDOW_UPDATE with unknown SID.
There's a race condition between closing a stream by one endpoint and sending a WINDOW_UPDATE frame by another. So it would be better to just skip such frames for unknown streams, like is already done for the DATA frames.
Diffstat (limited to 'src')
-rw-r--r--src/http/ngx_http_spdy.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/http/ngx_http_spdy.c b/src/http/ngx_http_spdy.c
index 9d6b67f80..a09e4ac0b 100644
--- a/src/http/ngx_http_spdy.c
+++ b/src/http/ngx_http_spdy.c
@@ -1341,16 +1341,8 @@ ngx_http_spdy_state_window_update(ngx_http_spdy_connection_t *sc, u_char *pos,
stream = ngx_http_spdy_get_stream_by_id(sc, sid);
if (stream == NULL) {
- ngx_log_error(NGX_LOG_INFO, sc->connection->log, 0,
- "client sent WINDOW_UPDATE frame "
- "for unknown stream %ui", sid);
-
- if (ngx_http_spdy_send_rst_stream(sc, sid, NGX_SPDY_INVALID_STREAM,
- NGX_SPDY_LOWEST_PRIORITY)
- == NGX_ERROR)
- {
- return ngx_http_spdy_state_internal_error(sc);
- }
+ ngx_log_debug0(NGX_LOG_DEBUG_HTTP, sc->connection->log, 0,
+ "unknown spdy stream");
return ngx_http_spdy_state_complete(sc, pos, end);
}