diff options
| author | Vladimir Homutov <vl@nginx.com> | 2021-12-01 18:33:29 +0300 |
|---|---|---|
| committer | Vladimir Homutov <vl@nginx.com> | 2021-12-01 18:33:29 +0300 |
| commit | 468641cbc30c67bef830d92b7a84044c6a09378e (patch) | |
| tree | 72cee9ebfa0fb9a88b3b80b9c3fa13cc9de936ff /src | |
| parent | a981efe6e803acc17af428ea16385df1e8e05c00 (diff) | |
| download | nginx-468641cbc30c67bef830d92b7a84044c6a09378e.tar.gz nginx-468641cbc30c67bef830d92b7a84044c6a09378e.zip | |
QUIC: removed excessive check.
The c->udp->dgram may be NULL only if the quic connection was just
created: the ngx_event_udp_recvmsg() passes information about datagrams
to existing connections by providing information in c->udp.
If case of a new connection, c->udp is allocated by the QUIC code during
creation of quic connection (it uses c->sockaddr to initialize qsock->path).
Thus the check for qsock->path is excessive and can be read wrong, assuming
that other options possible, leading to warnings from clang static analyzer.
Diffstat (limited to 'src')
| -rw-r--r-- | src/event/quic/ngx_event_quic_migration.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/event/quic/ngx_event_quic_migration.c b/src/event/quic/ngx_event_quic_migration.c index 887824573..c3758ad4f 100644 --- a/src/event/quic/ngx_event_quic_migration.c +++ b/src/event/quic/ngx_event_quic_migration.c @@ -289,7 +289,7 @@ ngx_quic_update_paths(ngx_connection_t *c, ngx_quic_header_t *pkt) qsock = ngx_quic_get_socket(c); - if (c->udp->dgram == NULL && qsock->path) { + if (c->udp->dgram == NULL) { /* 1st ever packet in connection, path already exists */ path = qsock->path; goto update; |