diff options
| author | Valentin Bartenev <vbart@nginx.com> | 2013-03-25 15:49:11 +0000 |
|---|---|---|
| committer | Valentin Bartenev <vbart@nginx.com> | 2013-03-25 15:49:11 +0000 |
| commit | 604e18fb2c97b86b49b93b969d55003c9656f143 (patch) | |
| tree | a93a3ba36cf535d7aed22f8d647e1a2e79a7fde5 /src/os/unix/ngx_process_cycle.c | |
| parent | ea327f13f130be87cf3023e215d1c97b5465343f (diff) | |
| download | nginx-604e18fb2c97b86b49b93b969d55003c9656f143.tar.gz nginx-604e18fb2c97b86b49b93b969d55003c9656f143.zip | |
Use NGX_FILE_ERROR for handling file operations errors.
On Win32 platforms 0 is used to indicate errors in file operations, so
comparing against -1 is not portable.
This was not much of an issue in patched code, since only ngx_fd_info() test
is actually reachable on Win32 and in worst case it might result in bogus
error log entry.
Patch by Piotr Sikora.
Diffstat (limited to 'src/os/unix/ngx_process_cycle.c')
| -rw-r--r-- | src/os/unix/ngx_process_cycle.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/os/unix/ngx_process_cycle.c b/src/os/unix/ngx_process_cycle.c index c9b0266ed..dfdfae081 100644 --- a/src/os/unix/ngx_process_cycle.c +++ b/src/os/unix/ngx_process_cycle.c @@ -647,7 +647,7 @@ ngx_reap_children(ngx_cycle_t *cycle) if (ngx_rename_file((char *) ccf->oldpid.data, (char *) ccf->pid.data) - != NGX_OK) + == NGX_FILE_ERROR) { ngx_log_error(NGX_LOG_ALERT, cycle->log, ngx_errno, ngx_rename_file_n " %s back to %s failed " |