diff options
author | Ruslan Ermilov <ru@nginx.com> | 2017-06-14 12:49:20 +0300 |
---|---|---|
committer | Ruslan Ermilov <ru@nginx.com> | 2017-06-14 12:49:20 +0300 |
commit | fa0992ed295ba83f711ca3d1ba8fc1baaa5760ca (patch) | |
tree | 27f6d2a3fb5e068ba1f3ef2de9a15d89c735c27d /src/http/ngx_http_request.h | |
parent | 731d1fee8a64538882f4a7c0d2cce1137410cb15 (diff) | |
download | nginx-fa0992ed295ba83f711ca3d1ba8fc1baaa5760ca.tar.gz nginx-fa0992ed295ba83f711ca3d1ba8fc1baaa5760ca.zip |
Gzip: fixed style in $gzip_ratio variable handler.
The current style in variable handlers returning NGX_OK is to either set
v->not_found to 1, or to initialize the entire ngx_http_variable_value_t
structure.
In theory, always setting v->valid = 1 for NGX_OK would be useful, which
would mean that the value was computed and is thus valid, including the
special case of v->not_found = 1. But currently that's not the case and
causes the (v->valid || v->not_found) check to access an uninitialized
v->valid value, which is safe only because its value doesn't matter when
v->not_found is set.
Diffstat (limited to 'src/http/ngx_http_request.h')
0 files changed, 0 insertions, 0 deletions