diff options
| author | Sergey Kandaurov <pluknet@nginx.com> | 2021-12-07 15:49:51 +0300 |
|---|---|---|
| committer | Sergey Kandaurov <pluknet@nginx.com> | 2021-12-07 15:49:51 +0300 |
| commit | a42a62fc583ad311d06a90e3bcd12d63df0701a4 (patch) | |
| tree | b913d59f2ef70010cd9ebf070ea832a4574247fd /src/http/ngx_http_request.c | |
| parent | 9860a82b195afb9c8d7a98536c752927b677736b (diff) | |
| download | nginx-a42a62fc583ad311d06a90e3bcd12d63df0701a4.tar.gz nginx-a42a62fc583ad311d06a90e3bcd12d63df0701a4.zip | |
QUIC: clear SSL_OP_ENABLE_MIDDLEBOX_COMPAT on SSL context switch.
The SSL_OP_ENABLE_MIDDLEBOX_COMPAT option is provided by QuicTLS and enabled
by default in the newly created SSL contexts. SSL_set_quic_method() is used
to clear it, which is required for SSL handshake to work on QUIC connections.
Switching context in the ngx_http_ssl_servername() SNI callback overrides SSL
options from the new SSL context. This results in the option set again.
Fix is to explicitly clear it when switching to another SSL context.
Initially reported here (in Russian):
http://mailman.nginx.org/pipermail/nginx-ru/2021-November/063989.html
Diffstat (limited to 'src/http/ngx_http_request.c')
| -rw-r--r-- | src/http/ngx_http_request.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index e8907c100..32a26379c 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c @@ -954,6 +954,14 @@ ngx_http_ssl_servername(ngx_ssl_conn_t *ssl_conn, int *ad, void *arg) #ifdef SSL_OP_NO_RENEGOTIATION SSL_set_options(ssl_conn, SSL_OP_NO_RENEGOTIATION); #endif + +#ifdef SSL_OP_ENABLE_MIDDLEBOX_COMPAT +#if (NGX_HTTP_QUIC) + if (c->listening->quic) { + SSL_clear_options(ssl_conn, SSL_OP_ENABLE_MIDDLEBOX_COMPAT); + } +#endif +#endif } done: |