aboutsummaryrefslogtreecommitdiff
path: root/src/http/ngx_http_request.c
diff options
context:
space:
mode:
authorValentin Bartenev <vbart@nginx.com>2016-05-13 17:19:23 +0300
committerValentin Bartenev <vbart@nginx.com>2016-05-13 17:19:23 +0300
commit12f436718963f8343e38ad6d0e8f7251c95984cd (patch)
tree89b72bfa6fd419e2049c5e01d8d4166d3f065b44 /src/http/ngx_http_request.c
parentcbf6ca98bc3f839ab3519ac45807c3c8ae6deb84 (diff)
downloadnginx-12f436718963f8343e38ad6d0e8f7251c95984cd.tar.gz
nginx-12f436718963f8343e38ad6d0e8f7251c95984cd.zip
Improved EPOLLRDHUP handling.
When it's known that the kernel supports EPOLLRDHUP, there is no need in additional recv() call to get EOF or error when the flag is absent in the event generated by the kernel. A special runtime test is done at startup to detect if EPOLLRDHUP is actually supported by the kernel because epoll_ctl() silently ignores unknown flags. With this knowledge it's now possible to drop the "ready" flag for partial read. Previously, the "ready" flag was kept until the recv() returned EOF or error. In particular, this change allows the lingering close heuristics (which relies on the "ready" flag state) to actually work on Linux, and not wait for more data in most cases. The "available" flag is now used in the read event with the semantics similar to the corresponding counter in kqueue.
Diffstat (limited to 'src/http/ngx_http_request.c')
-rw-r--r--src/http/ngx_http_request.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c
index 7d6cada4d..aa3c398a3 100644
--- a/src/http/ngx_http_request.c
+++ b/src/http/ngx_http_request.c
@@ -2752,9 +2752,13 @@ ngx_http_test_reading(ngx_http_request_t *r)
#if (NGX_HAVE_EPOLLRDHUP)
- if ((ngx_event_flags & NGX_USE_EPOLL_EVENT) && rev->pending_eof) {
+ if ((ngx_event_flags & NGX_USE_EPOLL_EVENT) && ngx_use_epoll_rdhup) {
socklen_t len;
+ if (!rev->pending_eof) {
+ return;
+ }
+
rev->eof = 1;
c->error = 1;