diff options
author | Sergey Kandaurov <pluknet@nginx.com> | 2021-09-29 15:01:59 +0300 |
---|---|---|
committer | Sergey Kandaurov <pluknet@nginx.com> | 2021-09-29 15:01:59 +0300 |
commit | dab6035d68f3dd3f212393635c193c7aefea0d65 (patch) | |
tree | 023e10d3fdbc97ebc110ef7837c5fc85a5b67bd8 /src/http/modules/ngx_http_quic_module.c | |
parent | 1ea6f35fbfecadfe3e78c4b59b8c03a97b696d15 (diff) | |
download | nginx-dab6035d68f3dd3f212393635c193c7aefea0d65.tar.gz nginx-dab6035d68f3dd3f212393635c193c7aefea0d65.zip |
HTTP/3: fixed segfault when using SSL certificates with variables.
A QUIC connection doesn't have c->log->data and friends initialized to sensible
values. Yet, a request can be created in the certificate callback with such an
assumption, which leads to a segmentation fault due to null pointer dereference
in ngx_http_free_request(). The fix is to adjust initializing the QUIC part of
a connection such that it has all of that in place.
Further, this appends logging error context for unsuccessful QUIC handshakes:
- cannot load certificate .. while handling frames
- SSL_do_handshake() failed .. while sending frames
Diffstat (limited to 'src/http/modules/ngx_http_quic_module.c')
-rw-r--r-- | src/http/modules/ngx_http_quic_module.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/http/modules/ngx_http_quic_module.c b/src/http/modules/ngx_http_quic_module.c index b41c069b6..ce13a223f 100644 --- a/src/http/modules/ngx_http_quic_module.c +++ b/src/http/modules/ngx_http_quic_module.c @@ -198,8 +198,6 @@ ngx_http_quic_init(ngx_connection_t *c) hc->ssl = 1; if (c->quic == NULL) { - c->log->connection = c->number; - qcf = ngx_http_get_module_srv_conf(hc->conf_ctx, ngx_http_quic_module); ngx_quic_run(c, qcf); |