aboutsummaryrefslogtreecommitdiff
path: root/src/http/modules/ngx_http_grpc_module.c
diff options
context:
space:
mode:
authorPavel Pautov <p.pautov@f5.com>2020-11-18 18:41:16 -0800
committerPavel Pautov <p.pautov@f5.com>2020-11-18 18:41:16 -0800
commit671cbc18409ec726a540b5cfc0f88bbdc5dba2f1 (patch)
treeb3a22ec829eaf91ad69892b8ffa501f5cb8f2ace /src/http/modules/ngx_http_grpc_module.c
parent01ed3c3591fe5becf291a04585dfdd0551f9455f (diff)
downloadnginx-671cbc18409ec726a540b5cfc0f88bbdc5dba2f1.tar.gz
nginx-671cbc18409ec726a540b5cfc0f88bbdc5dba2f1.zip
gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.
Similarly to the problem fixed in 2096b21fcd10 (ticket #1792), when a "trailer only" gRPC response (that is, a response with the END_STREAM flag in the HEADERS frame) was immediately followed by RST_STREAM(NO_ERROR) in the data preread along with the response header, RST_STREAM wasn't properly skipped and caused "upstream rejected request with error 0" errors. Observed with "unknown service" gRPC errors returned by grpc-go. Fix is to set ctx->done if we are going to parse additional data, so the RST_STREAM(NO_ERROR) is properly skipped. Additionally, now ngx_http_grpc_filter() will complain about frames sent for closed stream if there are any.
Diffstat (limited to 'src/http/modules/ngx_http_grpc_module.c')
-rw-r--r--src/http/modules/ngx_http_grpc_module.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/http/modules/ngx_http_grpc_module.c b/src/http/modules/ngx_http_grpc_module.c
index 0b8bb5281..aa7576561 100644
--- a/src/http/modules/ngx_http_grpc_module.c
+++ b/src/http/modules/ngx_http_grpc_module.c
@@ -1969,6 +1969,7 @@ ngx_http_grpc_filter_init(void *data)
}
u->length = 0;
+ ctx->done = 1;
} else {
u->length = 1;