aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxim Dounin <mdounin@mdounin.ru>2011-11-29 17:27:13 +0000
committerMaxim Dounin <mdounin@mdounin.ru>2011-11-29 17:27:13 +0000
commitc09d65b17990c6c4028df68dfab7a7452ef16d00 (patch)
tree84560374a99b02b6e8ec419805b6da4cad3b0864
parentb99492595c7dbb8f6449e5e59689ffdcf95c83e3 (diff)
downloadnginx-c09d65b17990c6c4028df68dfab7a7452ef16d00.tar.gz
nginx-c09d65b17990c6c4028df68dfab7a7452ef16d00.zip
Fixed AIO on Linux, broken in r4306.
Events from eventfd do not have c->write set, and the stale event check added in r4306 causes null pointer dereference.
-rw-r--r--src/event/modules/ngx_epoll_module.c20
1 files changed, 10 insertions, 10 deletions
diff --git a/src/event/modules/ngx_epoll_module.c b/src/event/modules/ngx_epoll_module.c
index 4f9c5118e..f4003af70 100644
--- a/src/event/modules/ngx_epoll_module.c
+++ b/src/event/modules/ngx_epoll_module.c
@@ -681,19 +681,19 @@ ngx_epoll_process_events(ngx_cycle_t *cycle, ngx_msec_t timer, ngx_uint_t flags)
wev = c->write;
- if (c->fd == -1 || wev->instance != instance) {
+ if ((revents & EPOLLOUT) && wev->active) {
- /*
- * the stale event from a file descriptor
- * that was just closed in this iteration
- */
+ if (c->fd == -1 || wev->instance != instance) {
- ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
- "epoll: stale event %p", c);
- continue;
- }
+ /*
+ * the stale event from a file descriptor
+ * that was just closed in this iteration
+ */
- if ((revents & EPOLLOUT) && wev->active) {
+ ngx_log_debug1(NGX_LOG_DEBUG_EVENT, cycle->log, 0,
+ "epoll: stale event %p", c);
+ continue;
+ }
if (flags & NGX_POST_THREAD_EVENTS) {
wev->posted_ready = 1;