diff options
author | Valentin Bartenev <vbart@nginx.com> | 2012-08-08 12:03:46 +0000 |
---|---|---|
committer | Valentin Bartenev <vbart@nginx.com> | 2012-08-08 12:03:46 +0000 |
commit | 86dd5bde4590e60289cf2ae94afe2f9ab5d65f3c (patch) | |
tree | ecdea6f9f6c1b5bd3267726344d76159956b23ce | |
parent | 2af80d5fab3e3962baf38d65eebcfe79312ae32e (diff) | |
download | nginx-86dd5bde4590e60289cf2ae94afe2f9ab5d65f3c.tar.gz nginx-86dd5bde4590e60289cf2ae94afe2f9ab5d65f3c.zip |
Added three missing checks for NULL after ngx_array_push() calls.
Found by Coverity.
-rw-r--r-- | src/http/modules/ngx_http_fastcgi_module.c | 3 | ||||
-rw-r--r-- | src/http/modules/ngx_http_limit_conn_module.c | 4 | ||||
-rw-r--r-- | src/http/modules/ngx_http_limit_req_module.c | 3 |
3 files changed, 10 insertions, 0 deletions
diff --git a/src/http/modules/ngx_http_fastcgi_module.c b/src/http/modules/ngx_http_fastcgi_module.c index 55c3aef29..e8ff24cac 100644 --- a/src/http/modules/ngx_http_fastcgi_module.c +++ b/src/http/modules/ngx_http_fastcgi_module.c @@ -1626,6 +1626,9 @@ ngx_http_fastcgi_process_header(ngx_http_request_t *r) } part = ngx_array_push(f->split_parts); + if (part == NULL) { + return NGX_ERROR; + } part->start = part_start; part->end = part_end; diff --git a/src/http/modules/ngx_http_limit_conn_module.c b/src/http/modules/ngx_http_limit_conn_module.c index 106da7a53..e82ca493d 100644 --- a/src/http/modules/ngx_http_limit_conn_module.c +++ b/src/http/modules/ngx_http_limit_conn_module.c @@ -721,6 +721,10 @@ ngx_http_limit_conn(ngx_conf_t *cf, ngx_command_t *cmd, void *conf) } limit = ngx_array_push(&lccf->limits); + if (limit == NULL) { + return NGX_CONF_ERROR; + } + limit->conn = n; limit->shm_zone = shm_zone; diff --git a/src/http/modules/ngx_http_limit_req_module.c b/src/http/modules/ngx_http_limit_req_module.c index 18db71549..3f9910e71 100644 --- a/src/http/modules/ngx_http_limit_req_module.c +++ b/src/http/modules/ngx_http_limit_req_module.c @@ -937,6 +937,9 @@ ngx_http_limit_req(ngx_conf_t *cf, ngx_command_t *cmd, void *conf) } limit = ngx_array_push(&lrcf->limits); + if (limit == NULL) { + return NGX_CONF_ERROR; + } limit->shm_zone = shm_zone; limit->burst = burst * 1000; |